-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package tests should test using a custom ES_PATH_CONF #50273
Comments
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
I started trying to add this to the packaging tests, but stopped because this requires copying /etc/elasticsearch contents to the alternate ES_PATH_CONF after installing. It would also mean updating the elasticsearch package would not pickup updates to configuration files, even ones that may not be modified often by users like the log4j config. We may want to rethink this feature (and #24867) as this seems pretty difficult as it is for users to implement, so I'm not sure what the added benefit is. |
Just a quick reminder that the official Puppet modules will empty /etc/default/elasticsearch of all configuration, including ES_PATH_CONF, effectively rendering elasticsearch unable to upgrade through the deb package |
Pinging @elastic/es-delivery (Team:Delivery) |
Our RPM and Debian packages will now respect
ES_PATH_CONF
during installs, upgrades, and package removal. We do not have coverage for this though, our packaging tests use the default of/etc/elasticsearch
. In order to ensure that we maintain this behavior, our package tests should also run in a mode where they run the entire suite with a customES_PATH_CONF
(maybe randomized with a space in the name, to ensure that we have the quoting correct too).Relates #50158
Relates #50246
The text was updated successfully, but these errors were encountered: