Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package tests should test using a custom ES_PATH_CONF #50273

Open
jasontedor opened this issue Dec 17, 2019 · 4 comments
Open

Package tests should test using a custom ES_PATH_CONF #50273

jasontedor opened this issue Dec 17, 2019 · 4 comments
Assignees
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests

Comments

@jasontedor
Copy link
Member

Our RPM and Debian packages will now respect ES_PATH_CONF during installs, upgrades, and package removal. We do not have coverage for this though, our packaging tests use the default of /etc/elasticsearch. In order to ensure that we maintain this behavior, our package tests should also run in a mode where they run the entire suite with a custom ES_PATH_CONF (maybe randomized with a space in the name, to ensure that we have the quoting correct too).

Relates #50158
Relates #50246

@jasontedor jasontedor added the :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts label Dec 17, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Packaging)

@jasontedor jasontedor added v7.6.0 v8.0.0 >test Issues or PRs that are addressing/adding tests labels Dec 17, 2019
@rjernst
Copy link
Member

rjernst commented Dec 17, 2019

I started trying to add this to the packaging tests, but stopped because this requires copying /etc/elasticsearch contents to the alternate ES_PATH_CONF after installing. It would also mean updating the elasticsearch package would not pickup updates to configuration files, even ones that may not be modified often by users like the log4j config. We may want to rethink this feature (and #24867) as this seems pretty difficult as it is for users to implement, so I'm not sure what the added benefit is.

@mmomtchev
Copy link

Just a quick reminder that the official Puppet modules will empty /etc/default/elasticsearch of all configuration, including ES_PATH_CONF, effectively rendering elasticsearch unable to upgrade through the deb package

@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@bpintea bpintea added v7.8.0 and removed v7.7.0 labels Mar 25, 2020
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@andreidan andreidan added v7.11.0 and removed v7.10.0 labels Oct 7, 2020
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

No branches or pull requests