Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build context factories from AST rather than ASM #49875

Closed
stu-elastic opened this issue Dec 5, 2019 · 4 comments
Closed

Build context factories from AST rather than ASM #49875

stu-elastic opened this issue Dec 5, 2019 · 4 comments
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team

Comments

@stu-elastic
Copy link
Contributor

ASM is used to build the context factories on the fly. This task is to build the AST directly and use that to generate the ASM.

We'll be better able to reason about the generation process since ASM is difficult to read.

Migrated from: #31009
@stu-elastic stu-elastic added the :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache label Dec 5, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@jdconrad
Copy link
Contributor

jdconrad commented Dec 9, 2020

Done.

@jdconrad jdconrad removed the Team:Core/Infra Meta label for core/infra team label Dec 9, 2020
@jdconrad jdconrad closed this as completed Dec 9, 2020
@jdconrad
Copy link
Contributor

jdconrad commented Dec 9, 2020

Oops, thought this was a different issue.

@jdconrad jdconrad reopened this Dec 9, 2020
@jdconrad jdconrad added Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label labels Dec 9, 2020
@rjernst
Copy link
Member

rjernst commented May 25, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@rjernst rjernst closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache Team:Core/Infra Meta label for core/infra team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rjernst @jdconrad @elasticmachine @stu-elastic