Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to ensure the yaml tests parse #46636

Open
jasontedor opened this issue Sep 11, 2019 · 4 comments
Open

Add task to ensure the yaml tests parse #46636

jasontedor opened this issue Sep 11, 2019 · 4 comments
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@jasontedor
Copy link
Member

We should add a task, that precommit depends on, that ensures that all REST tests parse. This would catch issues where we are muting REST tests. Today we have a test-mute label to quickly get these mutes in via PRs, and that only runs precommit, but precommit wouldn't catch these issues today since it doesn't parse the REST tests.

@jasontedor jasontedor added the :Delivery/Build Build or test infrastructure label Sep 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member

rjernst commented Sep 11, 2019

I wonder if we could do this indirectly by changing rest tests to be generated java, so that instead of running parameterized junit, each test file is a generated junit suite. This would also solve the repro line problem in #41380.

@alpar-t
Copy link
Contributor

alpar-t commented Oct 9, 2019

Closing in favor of #47793

@jakelandis
Copy link
Contributor

We should consider introducing a JSON schema similar to #54252 and validating the tests against the schema. I know the tests are written in YAML, not JSON, but we should be able to easily programmatically convert via Jackson validation. It would catch parsing errors as well as rules that could be defined by the schema. I imagine the validation could re-use the gradle task introduced in #54252

@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
@mark-vieira mark-vieira added Team:Delivery Meta label for Delivery team and removed Team:Core/Infra Meta label for core/infra team labels Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

No branches or pull requests

6 participants