Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Fix issue with CSV testing regarding timestamp milliseconds #46511

Closed
matriv opened this issue Sep 9, 2019 · 2 comments
Closed

SQL: Fix issue with CSV testing regarding timestamp milliseconds #46511

matriv opened this issue Sep 9, 2019 · 2 comments
Labels
:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests

Comments

@matriv
Copy link
Contributor

matriv commented Sep 9, 2019

As seen here: https://github.com/elastic/elasticsearch/pull/46473/files#diff-cf94de789c0241585ea4400a0761e0f9R125 the .XXX milliseconds part of the expected timestamp is ignored and currently the work around is to cast the timestamp result columns as string in order to properly assert them.

The issue should be fixed either through CsvTestUtils or maybe by patching the 3rd party csvjdbc library .
@matriv matriv added >test Issues or PRs that are addressing/adding tests :Analytics/SQL SQL querying labels Sep 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@matriv matriv mentioned this issue Sep 9, 2019
Merged
@matriv
Copy link
Contributor Author

matriv commented Apr 9, 2020

Superseded by #54947

@matriv matriv closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matriv @elasticmachine