-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the snippets more "asciidoctor" standard #46189
Comments
Pinging @elastic/es-docs |
#46295 switches all the // TESTRESPONSE comments over. |
Once #46353 and #46440 are merged, we can consider this near complete. However, there are likely pending PRs that still contain the old magic comments. @nik9000 Are we planning to remove support for those magic comments? If so, we may want to do a coordinated "final cleanup" right beforehand. We'd also want some way to address pending PRs that have already passed CI but would fail in production if support was removed. All that is moot if we want to continue supporting both. |
Closing this as #46936 ends support for 7.4 acts as a 'bridge' branch where both |
This is to track the cleanup that we can do to the docs after #46180 and #45937. That is:
[source,js]
with[source,console]
// CONSOLE
[source,js]
with[source,console-result]
// TESTRESPONSE
if it doesn't have any special operations likes
The first on is nice because it makes the docs consistent with how they actually work in Asciidoctor. The second one does that too but also will allow clients to override those snippets when they are overriding request snippets.
The text was updated successfully, but these errors were encountered: