Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up resources shared between x-pack core and security #41646

Open
jaymode opened this issue Apr 29, 2019 · 1 comment
Open

Clean up resources shared between x-pack core and security #41646

jaymode opened this issue Apr 29, 2019 · 1 comment
Labels
:Security/Security Security issues without another label Team:Security Meta label for security team

Comments

@jaymode
Copy link
Member

jaymode commented Apr 29, 2019

There are a large number of certificates that we have checked in as test resources. Both the x-pack core and security projects have the same paths and many of the same names for certificates and keystores. However, the content has diverged in some of the files. This would be fine if the projects were completely separated but as it stands the core resources are copied into the security source set for tests. This can lead to confusing failures if you are not aware of this and do not know which file is actually being used, which happened to me while working on cipher changes for JDK 11.

We should either remove the sharing of these resources or only keep them in core so that we do not have this situation where files diverge and we're unsure of which files are being used.

@jaymode jaymode added the :Security/Security Security issues without another label label Apr 29, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@rjernst rjernst added the Team:Security Meta label for security team label May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/Security Security issues without another label Team:Security Meta label for security team
Projects
None yet
Development

No branches or pull requests

3 participants