Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RFC7231 UserAgent scheme in User Agent processor. #41001

Closed
Mpdreamz opened this issue Apr 9, 2019 · 2 comments
Closed

Support RFC7231 UserAgent scheme in User Agent processor. #41001

Mpdreamz opened this issue Apr 9, 2019 · 2 comments
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team

Comments

@Mpdreamz
Copy link
Member

Mpdreamz commented Apr 9, 2019

https://tools.ietf.org/html/rfc7231#section-5.5.3 defines user agent headers as:

     User-Agent = product *( RWS ( product / comment ) )

Example:
     User-Agent: CERN-LineMode/2.15 libwww/2.17b3

However the UA processor does not seem to support this OOTB

PUT _ingest/pipeline/user_agent
{
  "description" : "Add user agent information",
  "processors" : [
    {
      "user_agent" : {
        "field" : "agent"
      }
    }
  ]
}


PUT my_index/_doc/1?pipeline=user_agent&refresh=true
{
  "agent": "CERN-LineMode/2.15 libwww/2.17b3"
}

GET my_index/_doc/1

yields:

# GET my_index/_doc/1
{
  "_index" : "my_index",
  "_type" : "_doc",
  "_id" : "1",
  "_version" : 1,
  "_seq_no" : 0,
  "_primary_term" : 1,
  "found" : true,
  "_source" : {
    "agent" : "CERN-LineMode/2.15 libwww/2.17b3",
    "user_agent" : {
      "original" : "CERN-LineMode/2.15 libwww/2.17b3",
      "name" : "Other",
      "device" : {
        "name" : "Other"
      }
    }
  }
}

It would be nice if version would be set to 2.15 and name to CERN-LineMode without requiring a custom ua parser file.

@costin costin added the :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP label Apr 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@dakrone
Copy link
Member

dakrone commented May 17, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@dakrone dakrone closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP >enhancement Team:Data Management Meta label for data/management team
Projects
None yet
Development

No branches or pull requests

6 participants