Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher: DRY for waiting for watcher to start/stop in Integration tests #35348

Closed
jakelandis opened this issue Nov 7, 2018 · 3 comments
Closed

Watcher: DRY for waiting for watcher to start/stop in Integration tests #35348

jakelandis opened this issue Nov 7, 2018 · 3 comments
Labels
:Data Management/Watcher >non-issue >refactoring Team:Data Management Meta label for data/management team

Comments

@jakelandis
Copy link
Contributor

The following tests all perform similar (same?) logic to busy wait start and stop Watcher:

  • SmokeTestWatcherWithSecurityIT
  • SmokeTestWatcherWithSecurityClientYamlTestSuiteIT
  • SmokeTestWatcherTestSuiteIT
  • WatcherRestIT
  • XDocsClientYamlTestSuiteIT
  • XPackRestIT

Ideally there wouldn't be so much copy paste as evident by #35271.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jakelandis jakelandis changed the title Watcher: DRY for waiting for watcher to start in Integration tests Watcher: DRY for waiting for watcher to start/stop in Integration tests Nov 7, 2018
@nik9000 nik9000 self-assigned this Nov 8, 2018
@nik9000
Copy link
Member

nik9000 commented Nov 8, 2018

We've been wanting to move the watcher docs from the x-pack/docs folder to the docs folder and one of the blockers is having a consistent way to do this waiting. I intend to work on it at some point so I'm assigning it to me. But if anyone else is keen to work on it I'm happy to give it up and talk through what I've been thinking.

@nik9000 nik9000 removed their assignment Jan 6, 2020
@rjernst rjernst added the Team:Data Management Meta label for data/management team label May 4, 2020
@dakrone
Copy link
Member

dakrone commented May 8, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@dakrone dakrone closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Watcher >non-issue >refactoring Team:Data Management Meta label for data/management team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dakrone @nik9000 @rjernst @jakelandis @elasticmachine