Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check mustache syntax at watcher creation time #35189

Closed
matschaffer opened this issue Nov 2, 2018 · 2 comments
Closed

Check mustache syntax at watcher creation time #35189

matschaffer opened this issue Nov 2, 2018 · 2 comments

Comments

@matschaffer
Copy link
Contributor

Describe the feature:

We had a case recently where we forgot a closing {{/ctx.payload.clusters}} on a watch.

This caused the watch to fail execution and essentially silence the alert until someone checked the kibana management UI.

While we should be doing better validation of watch changes, it could also be helpful if watcher validated mustache syntax when PUTing the watch definition and returned some sort of 4xx in the event of a syntax error.

Opening this bug specifically about mustache templates in actions, but I could see this potentially applying to painless transformations if that's not being checked already.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dakrone
Copy link
Member

dakrone commented May 8, 2024

This has been open for quite a while, and we haven't made much progress on this due to focus in other areas. For now I'm going to close this as something we aren't planning on implementing. We can re-open it later if needed.

@dakrone dakrone closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants