Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Address parsing deprecated and removed features in Datafeed Config #34858

Closed
davidkyle opened this issue Oct 25, 2018 · 3 comments
Closed
Labels
>feature :ml Machine learning

Comments

@davidkyle
Copy link
Member

Relates to the Job in Index feature branch.

Part of the motivation behind the migration project was to avoid the problem of parsing a datafeed that uses deprecated then removed features throwing an error. This remains an issue after migration as the config including search and aggs is parsed on GET. For the UI this means the datafeed cannot be displayed as the GET request will fail making it difficult to identify and fix the problem. The document can be read directly from elasticsearch if its name and location is known.

For REST GET requests where JSON is returned the config does not have to be parsed, internally the document is parsed for unmarshalling but this is not necessary for returning raw JSON. Additionally deprecation checks could be made by trying to parse the config and returning any deprecations in a warning header or by marking up the JSON object.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor

#30084 also discusses the same problem.

@droberts195
Copy link
Contributor

This is fixed by #36117 and #36233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :ml Machine learning
Projects
None yet
Development

No branches or pull requests

3 participants