Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Java 11 finds fault with Kerberos Javadocs #32461

Closed
droberts195 opened this issue Jul 30, 2018 · 1 comment · Fixed by #32469
Closed

[CI] Java 11 finds fault with Kerberos Javadocs #32461

droberts195 opened this issue Jul 30, 2018 · 1 comment · Fixed by #32469
Assignees
@bizybot
Labels
jdk11 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test-failure Triaged test failures from CI v7.0.0-beta1

Comments

@droberts195
Copy link
Contributor

Java 11 doesn't like the Javadocs for the Kerberos support that was added in #32263.

Mainly it doesn't like @throws with no description, but there's also one incorrect parameter name.

This is the full list of Javadoc problems Java 11 reports:

/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosTestCase.java:136: warning: no description for @throws
> Task :x-pack:plugin:security:compileTestJava
Build cache key for task ':x-pack:plugin:security:compileTestJava' is 9ab3c19b7803bce9bde2e99b98f414c6
     * @throws Exception
       ^
Task ':x-pack:plugin:security:compileTestJava' is not up-to-date because:
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosTestCase.java:149: warning: no description for @throws
     * @throws Exception
       ^
  No history is available.
All input files are considered out-of-date for incremental task ':x-pack:plugin:security:compileTestJava'.
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosTestCase.java:171: error: unknown tag: T
     * @return <T> Type of value as returned by PrivilegedAction
               ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosTestCase.java:172: warning: no description for @throws
     * @throws PrivilegedActionException
       ^
:x-pack:plugin:security:compileTestJava - is not incremental (e.g. outputs have changed, no previous execution, etc.).
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/KerberosTestCase.java:184: warning: no description for @throws
Compiling with JDK Java compiler API.
     * @throws IOException
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SimpleKdcLdapServer.java:69: warning: no description for @throws
     * @throws Exception
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SimpleKdcLdapServer.java:197: warning: no description for @throws
     * @throws PrivilegedActionException
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SpnegoClient.java:70: warning: no description for @throws
     * @throws PrivilegedActionException
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SpnegoClient.java:71: warning: no description for @throws
     * @throws GSSException
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SpnegoClient.java:102: warning: no description for @throws
     * @throws PrivilegedActionException
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SpnegoClient.java:117: warning: no description for @throws
     * @throws PrivilegedActionException
       ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SpnegoClient.java:163: error: @param name not found
     * @param settings {@link Settings}
              ^
/var/lib/jenkins/workspace/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA/java11/ES_RUNTIME_JAVA/java10/nodes/virtual&&linux/x-pack/plugin/security/src/test/java/org/elasticsearch/xpack/security/authc/kerberos/SpnegoClient.java:166: warning: no description for @throws
     * @throws LoginException
       ^
@droberts195 droberts195 added >test-failure Triaged test failures from CI v7.0.0 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) jdk11 labels Jul 30, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@bizybot bizybot mentioned this issue Jul 30, 2018
Merged
vladimirdolzhenko referenced this issue in vladimirdolzhenko/elasticsearch Jul 31, 2018
@bizybot
[Kerberos] Add missing javadocs (elastic#32469)
d4ea440 
This commit adds missing javadocs and fixes few where
the build failed when using JDK 11 for compilation.

Closes#32461
jdconrad referenced this issue in jdconrad/elasticsearch Jul 31, 2018
@bizybot @danielmitterdorfer
[Kerberos] Add missing javadocs (elastic#32469)
4638b7c 
This commit adds missing javadocs and fixes few where
the build failed when using JDK 11 for compilation.

Closes#32461
Tim-Brooks referenced this issue in Tim-Brooks/elasticsearch Jul 31, 2018
@bizybot @danielmitterdorfer
[Kerberos] Add missing javadocs (elastic#32469)
6152569 
This commit adds missing javadocs and fixes few where
the build failed when using JDK 11 for compilation.

Closes#32461
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizybot bizybot

Labels
jdk11 :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) >test-failure Triaged test failures from CI v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Kerberos] Add missing javadocs bizybot/elasticsearch
4 participants
@colings86 @bizybot @droberts195 @elasticmachine