Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Investigate handling of shard failures in SQL requests #32284

Closed
imotov opened this issue Jul 23, 2018 · 2 comments
Closed

SQL: Investigate handling of shard failures in SQL requests #32284

imotov opened this issue Jul 23, 2018 · 2 comments
Assignees
@imotov
Labels
:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests

Comments

@imotov
Copy link
Contributor

imotov commented Jul 23, 2018

SQL users are expecting to receive all results. We need to make sure that we handle the shard failures in SQL request properly. Setting allow_partial_search_results to false and adding a test might be all that is required.
@imotov imotov added >bug :Analytics/SQL SQL querying labels Jul 23, 2018
@imotov imotov self-assigned this Jul 23, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@imotov imotov added >test Issues or PRs that are addressing/adding tests and removed >bug labels Jul 23, 2018
@imotov
Copy link
Contributor Author

imotov commented Jul 23, 2018

After discussion with @costin it turned out that we are already setting allow_partial_search_results to false globally.

imotov added a commit to imotov/elasticsearch that referenced this issue Jul 30, 2018
@imotov
SQL: Add test for handling of partial results
a2b8463 
Makes sure that partial results are rejected in the SQL mode.

Closes elastic#32284
@imotov imotov mentioned this issue Jul 30, 2018
Merged
imotov added a commit that referenced this issue Jul 31, 2018
@imotov
SQL: Add test for handling of partial results (#32474)
5fd7202 
Verifies that partial results are rejected by SQL requests.

Closes #32284
imotov added a commit that referenced this issue Jul 31, 2018
@imotov
SQL: Add test for handling of partial results (#32474)
957f140 
Verifies that partial results are rejected by SQL requests.

Closes #32284
@eskibars eskibars mentioned this issue Aug 25, 2018
Closed
@bpintea bpintea mentioned this issue Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imotov imotov

Labels
:Analytics/SQL SQL querying >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@imotov @elasticmachine