Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include java version information in reproduction info #31898

Closed
alpar-t opened this issue Jul 9, 2018 · 4 comments · Fixed by #32715
Closed

Include java version information in reproduction info #31898

alpar-t opened this issue Jul 9, 2018 · 4 comments · Fixed by #32715
Assignees
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@alpar-t
Copy link
Contributor

alpar-t commented Jul 9, 2018

As brought up in #31739 we should print the Java version in the reproduction line as:

JAVA_HOME=$JAVA10_HOME RUNTIME_JAVA_HOME=$JAVA11_HOME ./gradlew

This will work because the build already requires people to have these env vars set.
We could also include the full paths instead of the env vars, as the build will have to pass in information anyhow for this to work as the test runner will not be aware what was used to build the tests.

This will help reproduce issues that are specific to some java versions without requiring one to look at how the CI job is configured.

@alpar-t alpar-t added the :Delivery/Build Build or test infrastructure label Jul 9, 2018
@alpar-t alpar-t self-assigned this Jul 9, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member

rjernst commented Jul 9, 2018

We could also include the full paths instead of the env vars

In order to keep the ability to copy/paste a repro line from CI to my our own workstations, the env vars should be used.

But +1 to the idea in general.

@alpar-t
Copy link
Contributor Author

alpar-t commented Jul 25, 2018

Discussed with @jkakavas , this needs to be extended to FIPS.

@alpar-t
Copy link
Contributor Author

alpar-t commented Jul 25, 2018

I am considering adding a new parameter for run-time java such as -Druntime.java=11 or -Druntime.java=8fips. This will take precedence to RUNTIME_JAVA_HOME which we will keep for comparability. The property will use the JAVA11_HOME etc env vars that we already use to figure out the actual paths. This is so this will work well with the Gradle daemon on JDK 9+ where new daemons are not spawn for env changes and setting RUNTIME_JAVA_HOME might not have any effect.

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants