Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASM incompatibility between SQL/Painless and FeatureAwareCheck #31322

Closed
tvernum opened this issue Jun 14, 2018 · 4 comments
Closed

ASM incompatibility between SQL/Painless and FeatureAwareCheck #31322

tvernum opened this issue Jun 14, 2018 · 4 comments
Labels
>bug :Delivery/Build Build or test infrastructure jdk10 Team:Delivery Meta label for Delivery team v6.4.0 v7.0.0-beta1

Comments

@tvernum
Copy link
Contributor

tvernum commented Jun 14, 2018

The X-Pack FeatureAwareCheck (#31081) requires ASM 6 (in order to parse recent class file formats).
Painless uses ASM 5, and SQL is now dependent on painless (#30681).

That means that when the feature aware check runs for SQL it has both versions of asm on the commandline and asm 5 gets used which fails to read the JRE's classes.

I pushed 89a2469 to work around it and get the build running again, but I think a better fix is in order.

@tvernum tvernum added :Delivery/Build Build or test infrastructure :Analytics/SQL SQL querying labels Jun 14, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@tvernum
Copy link
Contributor Author

tvernum commented Jun 14, 2018

@costin
Copy link
Member

costin commented Jun 15, 2018

Fixed by f7a0caf and 8305332

@costin costin closed this as completed Jun 15, 2018
@jpountz jpountz added >bug and removed :Analytics/SQL SQL querying labels Jan 29, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Build Build or test infrastructure jdk10 Team:Delivery Meta label for Delivery team v6.4.0 v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

6 participants