Timeout is not respected

[lmenezes]

On this issue #3128
if I add a timeout to the query(1ms, for example), the query instantly returns with no results, which is what I would expect.
But if the timeout is big enough(as to allow finding the document), then the query doesn't return at all,which is not what I would expect.
I guess this is the "desired" behavior, since the idea is to return whatever documents could be found before the timeout, and then highlight it and etc.
But if there are such cases where the highlighting is actually the "heavy" part of the query, doesn't it make sense to apply the timeout globally?

[kimchy]

yea, this is the current behavior, where the timeout applies to the query execution part, and it is the intended behavior. It does make sense to allow for timeouts to apply to other aspects, but it gets tricky in terms of definition since what will end up being returned in some of those cases is tricky to define.

[lmenezes]

@kimchy true... But on the other hand, if I set a timeout of 3000ms for example, it just means I'm not willing to wait for more than that, and will timeout to the end client anyway.
Even though I can see all the benefits of timing out and still retrieving maybe a "partial result set", I think its even more useful to know that I wont have long queries running using resources when I don't care about their result anymore.
Maybe an "abort_on_timeout" option could do the trick and still maintaing the partial result timeout?

[clintongormley]

Closed in favour of #4586