-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percolator not working with referenced parent/child queries #2960
Comments
Because the percolator API is processing one document at a time, it doesn’t support queries and filters that run against child and nested documents such as has_child, has_parent, top_children, and nested. |
Nested documents support was added to the percolator in #5082. Parent/child is still not supported but we might be able to support it in the future, reopening this issue in the meantime. |
+1, we have a strong need for this. |
Any information about Parent/Child document support in future version ? Having an application based on this kind of relations and I am stuck while using percolator |
We would have a need for this also. Currently we've had to refactor our child documents into nested fields inside the parent doc. The trade off here is that our parent docs are being reindexed faster than they other would. Doesn't dramatically impact our deployment but would prefer to leverage child documents for their strengths in conjunction with percolators. |
@martijnvg do you think it is feasible that we could support parent/child in the percolator in the future? Or is it just a no go? |
Actually after thinking about this for a while, support for parent/child in the percolator doesn't make a ton of sense, at least for our use case. One of the main reasons to use child documents in the first place is that you anticipate a lot of writes and don't want to trigger a parent doc reindex every time. We have decently high cardinality (high hundreds in some cases) with our child documents so paging every single one of those into memory to throw against the percolator would prove to be prohibitive as the data set continues to grow. I suspect this was one of the reasons why it was not supported in the first place. |
@mgreene @clintongormley I think ES can support parent/child queries in the percolator, but it is odd to do this for the reasons @mgreene mentioned. (store the documents in memory and toss it away and perform the next percolator request). What I think would be a nice addition to the percolator is to support percolating multiple documents in a single percolator call. So instead of defining a single |
I suggest that we document that the percolator does not support parent/child queries and close this. |
The fact that these queries can't be used is already documented: https://github.com/elastic/elasticsearch/blob/master/docs/reference/mapping/types/percolator.asciidoc#limitations In order to make it more clear that these queries are not supported, I also suggest that fail adding a percolator query that contains a |
+1 |
Thanks @martijnvg ! |
I have a
parent
and achild
collection. The child has the parent properly declared, and all the _search queries seem to be working correctly. But the percolator doesn't seem to work with the has_child query. Is this feature implemented?The text was updated successfully, but these errors were encountered: