Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep tombstones for expired search context ids #29543

Closed
jimczi opened this issue Apr 16, 2018 · 2 comments
Closed

Keep tombstones for expired search context ids #29543

jimczi opened this issue Apr 16, 2018 · 2 comments
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@jimczi
Copy link
Contributor

jimczi commented Apr 16, 2018

Search contexts are expired by the search service if they are not accessed within a certain amount of time. Though we don't keep any information on expired search context and that means that users that tries to access them get a cryptic error saying that the search context cannot be found on some node.
It's also difficult to know when debugging such issues if the search context is not there because it was expired or because of a bug. When discussing #29252 @s1monw had the idea to keep a map of expired search context ids so that when a query tries to access these expired search contexts we can produce an error message that explains why this search context is not present anymore. This map could for instance contain the id of the search context and the timestamp of when it was expired. Of course we cannot keep these tombstones forever but since they are lightweight we can apply a different expiration period for them (at least longer than the expiration period of the original search context ;) ).

@jimczi jimczi added >enhancement discuss :Search/Search Search-related issues that do not fall into other categories labels Apr 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@javanna
Copy link
Member

javanna commented Nov 16, 2022

There are no current plans on implementing this. Closing.

@javanna javanna closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Development

No branches or pull requests

5 participants