Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elastic search documentation about merge scheduling does not explicitly state that index.merge.scheduler.max_thread_count is a shard level property #28518

Closed
ahadadi opened this issue Feb 5, 2018 · 6 comments
Assignees
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >docs General docs changes good first issue low hanging fruit

Comments

@ahadadi
Copy link

ahadadi commented Feb 5, 2018

Elastic search documentation about merge scheduling does not explicitly state that index.merge.scheduler.max_thread_count is a shard level property.
The documentation states that this is The maximum number of threads that may be merging at once but this is true only on a shard level.
Specifically, this recommendation: If your index is on spinning platter drives instead, decrease this to 1 leads one to assume that the node disk write concurrency will be 1 which is the case only with one shard and one index on the node.

@polyfractal polyfractal added the >docs General docs changes label Feb 7, 2018
@polyfractal
Copy link
Contributor

I'm not sure I understand the issue? The setting is an index-level configuration, in that you configure it on a per-index basis. And the recommendation to decrease the number of merge threads if you're on a spinning drive is just to reduce IO contention, since spinning drives do not have nearly the random access IOPS that SSDs have.

What about the documentation should be updated? Not trying to be dense, just not sure I understand the issue :) Do you want it rephrased to something like:

The maximum number of threads on a single shard that may be merging at once

?

@ahadadi
Copy link
Author

ahadadi commented Feb 7, 2018

This rephrase is exactly what I had in mind :)

@ahadadi
Copy link
Author

ahadadi commented Mar 16, 2018

@polyfractal any thoughts about this?

@debadair debadair added the good first issue low hanging fruit label Mar 28, 2018
@colings86 colings86 added the :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. label Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@polyfractal
Copy link
Contributor

This fell through my radar, sorry for the silence. @Sue-Gallagher, was this fixed or merged somewhere?

@Sue-Gallagher
Copy link
Contributor

@polyfractal - no problem. All done PR #29686 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >docs General docs changes good first issue low hanging fruit
Projects
None yet
Development

No branches or pull requests

6 participants