Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format doc values fields #26948

Closed
jpountz opened this issue Oct 10, 2017 · 4 comments
Closed

Format doc values fields #26948

jpountz opened this issue Oct 10, 2017 · 4 comments
Labels
blocker >bug :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1

Comments

@jpountz
Copy link
Contributor

jpountz commented Oct 10, 2017

Follow-up of #22146, which has been stalled for a long time and probably needs to be re-done entirely now.

Currently docvalues_fields return the values of the fields as they are stored
in doc values. I don't like that it exposes implementation details, but there
are also user-facing issues like the fact it cannot work with binary fields.
This change will also make it easier for users to reindex if they do not store
the source, since docvalues_fields will return data is such a format that it
can be put in an indexing request with the same mappings.

@jpountz jpountz added :Search/Search Search-related issues that do not fall into other categories blocker >bug v7.0.0 labels Oct 10, 2017
@dakrone
Copy link
Member

dakrone commented Oct 17, 2017

Just a random aside, but it used to be the case with Kibana that they relied on
the non-formatting of doc_values for displaying data. For example, with dates
they used to ask for fielddata_fields/docvalues_fields of the date to get it
back in the epoch long format, rather than YYYY-mm-dd:HH:mm:ss,SSS (Kibana may
have since changed not to use it, I just wanted to leave a warning that we
should check).

@jpountz
Copy link
Contributor Author

jpountz commented Oct 17, 2017

Absolutely, this is actually the reason that I delayed the merging since it required synchronization with Kibana at a time when I had few free cycles.

@talevy
Copy link
Contributor

talevy commented Mar 23, 2018

Pinging @elastic/es-search-aggs

@jpountz
Copy link
Contributor Author

jpountz commented Feb 1, 2019

Fixed by #30831.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker >bug :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1
Projects
None yet
Development

No branches or pull requests

4 participants