Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop ScriptDocValues#date and ScriptDocValues#dates in 7.0.0 #23008

Closed
nik9000 opened this issue Feb 6, 2017 · 2 comments
Closed

Drop ScriptDocValues#date and ScriptDocValues#dates in 7.0.0 #23008

nik9000 opened this issue Feb 6, 2017 · 2 comments
Assignees
@jdconrad
Labels
>breaking :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.0.0-beta1

Comments

@nik9000
Copy link
Member

nik9000 commented Feb 6, 2017

ScriptDocValues#getDate and ScriptDocValues#getDates are used in 5.x to get ReadableDateTimes from ScriptDocValues of any numeric. In 6.0 we expect folks to get their ReadableDateTimes by calling ScriptDocValues#getValue or ScriptDocValues#getValues on date typed fields. This isn't possible in 5.x currently because date fields return millis-since-epoch from ReadableDateTime#value. In 7.0 we expect everyone will have migrated to getValue/getValues and we can remove getDate/getDates.
@nik9000 nik9000 added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >breaking v7.0.0 labels Feb 6, 2017
@nik9000
Copy link
Member Author

nik9000 commented Feb 6, 2017

Related to #22948.

@jdconrad jdconrad self-assigned this Mar 13, 2018
@nik9000
Copy link
Member Author

nik9000 commented Oct 16, 2018

@rjernst did this in #30690.

@nik9000 nik9000 closed this as completed Oct 16, 2018
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
@rjernst rjernst mentioned this issue Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdconrad jdconrad

Labels
>breaking :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nik9000 @jdconrad @jimczi