Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ignore allocation settings with cluster reroute #18321

Closed
clintongormley opened this issue May 13, 2016 · 7 comments
Closed

Don't ignore allocation settings with cluster reroute #18321

clintongormley opened this issue May 13, 2016 · 7 comments
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >enhancement good first issue low hanging fruit help wanted adoptme

Comments

@clintongormley
Copy link
Contributor

The cluster reroute command ignores the allocation deciders for index/cluster allocation settings, which makes it hard to debug why shards are not being assigned (see #18294 (comment))

@dakrone
Copy link
Member

dakrone commented May 13, 2016

I believe it should be an option to disable the allocation deciders when running reroute commands. I've disabled allocation and then manually allocated shards to be where I want them to be before in order to reproduce a specific cluster allocation

@clintongormley
Copy link
Contributor Author

clintongormley commented May 13, 2016

While that may be useful from a debugging perspective, it sounds very trappy for users The least we should do is report them as ignored in the explain output

Update: I was missing the context. I'm +1 on providing a flag to allow disabled allocation to be overridden with the cluster reroute command

@s1monw
Copy link
Contributor

s1monw commented May 13, 2016

Update: I was missing the context. I'm +1 on providing a flag to allow disabled allocation to be overridden with the cluster reroute command

+1 for now but in general we should really try to get away from providing this API alltogether

@abeyad abeyad self-assigned this May 16, 2016
@clintongormley
Copy link
Contributor Author

The flag should also allow overriding of the index.allocation.max_retry counter, which is being added in #18467

@bleskes
Copy link
Contributor

bleskes commented May 20, 2016

heads up to whoever implements this - some allocation deciders should never be overridden - for example ReplicaAfterPrimaryActiveAllocationDecider and SameShardAllocationDecider. These are so essential to how the code works, that I wonder if we should give them a special place/hard code them.

@abeyad abeyad removed their assignment May 20, 2016
@lcawl lcawl added :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. and removed :Allocation labels Feb 13, 2018
@DaveCTurner DaveCTurner added the :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) label Mar 15, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch ywelsch removed the :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. label Mar 27, 2018
@DaveCTurner
Copy link
Contributor

which makes it hard to debug why shards are not being assigned

We think this is now covered sufficiently well by the allocation explain API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >enhancement good first issue low hanging fruit help wanted adoptme
Projects
None yet
Development

No branches or pull requests

9 participants