Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default network.host to _non_loopback_ when using discovery.type:azure #13972

Closed
dadoonet opened this issue Oct 6, 2015 · 4 comments
Closed
Assignees
Labels
:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs won't fix

Comments

@dadoonet
Copy link
Member

dadoonet commented Oct 6, 2015

We should come with good defaults when using discovery.type: azure and bind network.host to _non_loopback_ (which is the private IP address - needed to be checked).

Related to #13969

@rmuir
Copy link
Contributor

rmuir commented Oct 6, 2015

I dont think we should ever default to this, its far too heuristicy and hacky. Really it should be deprecated, its totally arbitrary depending on interface ordering. Azure should have its own pseudo names like ec2 and the others... How we resolve them is an impl detail of that plugin.

Moreover i guess i missed where we again start binding to non local interfaces by default, but ill be damned if we leave it to luck with non loopback. If azure is not explicit like ec2 then we should add _site_local_ or something safer.

@dadoonet
Copy link
Member Author

dadoonet commented Oct 6, 2015

Yeah. I agree with you Robert. That's why I wrote which is the private IP address - needed to be checked. I thought it was. May it's not or too lenient.

I'll try first to see if we can implement _azure_ interface easily or not which is too me the best option.

@rmuir
Copy link
Contributor

rmuir commented Oct 6, 2015

I have the same concerns about the gce value in the referenced pr, it seems just as arbitrary, interface zero. If we want to bind to site local addresses for these plugins, then i would rather have a pseudo value that only binds to site local addresses. It seems to solve both these problems and we know it will not bind to anything crazy.

@dadoonet
Copy link
Member Author

dadoonet commented Oct 7, 2015

Closing for the same reasons as exposed in #13969 (comment)

@dadoonet dadoonet closed this as completed Oct 7, 2015
@clintongormley clintongormley added :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Discovery Azure Classic labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs won't fix
Projects
None yet
Development

No branches or pull requests

3 participants