Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default network.host to _ec2_ when using discovery.type:ec2 #13970

Closed
dadoonet opened this issue Oct 6, 2015 · 3 comments
Closed

default network.host to _ec2_ when using discovery.type:ec2 #13970

dadoonet opened this issue Oct 6, 2015 · 3 comments
Assignees
Labels
:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs won't fix

Comments

@dadoonet
Copy link
Member

dadoonet commented Oct 6, 2015

We should come with good defaults when using discovery.type: ec2 and bind network.host to _ec2_ (which is the private IP address).

Related to #13969

@dadoonet
Copy link
Member Author

dadoonet commented Oct 7, 2015

Closing for the same reasons as exposed in #13969 (comment)

@peterskim12
Copy link
Contributor

@dadoonet What do you think about logging a warning message suggesting that the user may want to consider changing network.host to ec2 if discovery.type: ec2? I gave some feedback to the doc team asking them to better call out the need to set network.host appropriately, but it's easy to miss.

@dadoonet
Copy link
Member Author

@peterskim12 Can you open a new issue for this so others can comment?

@clintongormley clintongormley added :Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs and removed :Plugin Discovery EC2 labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Discovery-Plugins Anything related to our integration plugins with EC2, GCP and Azure :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs won't fix
Projects
None yet
Development

No branches or pull requests

3 participants