Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otel-data: metric rejected when attribute contains data type long #112945

Closed
gregkalapos opened this issue Sep 16, 2024 · 4 comments · Fixed by #113409
Closed

otel-data: metric rejected when attribute contains data type long #112945

gregkalapos opened this issue Sep 16, 2024 · 4 comments · Fixed by #113409
Assignees
Labels

Comments

@gregkalapos
Copy link
Contributor

Elasticsearch Version

main

Installed Plugins

otel-data

Java Version

bundled

OS Version

Problem Description

Part of the OTel effort.

No user impact, this is disabled by default.

{
  "error": {
    "root_cause": [
      {
        "type": "mapper_parsing_exception",
        "reason": "Failed to parse mapping: Field [time_series_dimension] requires that [index] and [doc_values] are true"
      }
    ],
    "type": "mapper_parsing_exception",
    "reason": "Failed to parse mapping: Field [time_series_dimension] requires that [index] and [doc_values] are true",
    "caused_by": {
      "type": "illegal_argument_exception",
      "reason": "Field [time_series_dimension] requires that [index] and [doc_values] are true"
    }
  },
  "status": 400
}

That happens because some dynamic mappings with match_mapping_type set index: false - while those fields are set as dimension and index: false can't be set for dimensions.

Ideas so far: we move back the new metrics added into https://github.com/elastic/elasticsearch/blob/73e7b737ac17db1bc0f57891674e0b5efdf3d484/x-pack/plugin/core/template-resources/src/main/resources/metrics%40mappings.json into the otel-data plugin and if anything left, we can duplicate those and then leaving out the ones that set index: false.

Steps to Reproduce

POST metrics-generic.otel-test/_doc
{
  "@timestamp": "2024-09-06T13:52:20.000Z",
  "attributes": {
    "process.pid": 17
  }
}

Logs (if relevant)

No response

@gregkalapos gregkalapos added >bug needs:triage Requires assignment of a team area label labels Sep 16, 2024
@gregkalapos gregkalapos self-assigned this Sep 16, 2024
@pxsalehi
Copy link
Member

@gregkalapos which team in ES does this relate to?

@gregkalapos
Copy link
Contributor Author

@pxsalehi it'd be the data management team. But we take care of this within the OTel program and will ask them for review once there is a PR. That's why I assigned it to myself.

@gwbrown gwbrown added :Data Management/Monitoring and removed needs:triage Requires assignment of a team area label labels Sep 20, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Sep 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gwbrown
Copy link
Contributor

gwbrown commented Sep 20, 2024

Thanks, I've tagged this for the data management team. We just need an area team label on the thing for administrative purposes, even if it's assigned to an individual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants