Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESQL: Add test cases for functions not handling multivalues #112396

Open
ivancea opened this issue Aug 30, 2024 · 2 comments
Open

ESQL: Add test cases for functions not handling multivalues #112396

ivancea opened this issue Aug 30, 2024 · 2 comments
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@ivancea
Copy link
Contributor

ivancea commented Aug 30, 2024 •
edited
Loading

In a similar way to how we test that null parameters result in nulls automatically in AbstractFunctionTestCase, we should test that multivalued fields do the same.

Existing bugs detected here:
@ivancea ivancea added :Analytics/ES|QL AKA ESQL >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Aug 30, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@ivancea ivancea mentioned this issue Aug 30, 2024
Merged
@nik9000
Copy link
Member

nik9000 commented Aug 30, 2024

Interestingly, this aggs work quite differently than most functions here. But, yeah, I agree, we should do something automatic-ish.

@ivancea ivancea added >bug and removed >test Issues or PRs that are addressing/adding tests labels Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nik9000 @ivancea @elasticsearchmachine