Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore snapshot logs include too many indices #111872

Open
3 tasks
DaveCTurner opened this issue Aug 14, 2024 · 1 comment
Open
3 tasks

Restore snapshot logs include too many indices #111872

DaveCTurner opened this issue Aug 14, 2024 · 1 comment
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.

Comments

@DaveCTurner
Copy link
Contributor

The log message added in #88257 to indicate the start of a snapshot restore lists all the indices in the snapshot rather than just the ones we are restoring, which is confusing to users. Also the log message at the end doesn't indicate to which restore it pertains, and a user may issue in parallel several restore requests for indices from the same snapshot.

I think we should:

  • restrict the list of indices in the started restore of snapshot [... message to mention just the indices being restored
  • consider also calling out the feature states and whether we're restoring the global state
  • add the restore UUID to both messages, i.e. started restore [--UUID--] of snapshot [... and completed restore [--UUID--] of snapshot [... so that we can correlate the starts and ends.
@DaveCTurner DaveCTurner added >bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Aug 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Projects
None yet
Development

No branches or pull requests

2 participants