Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESQL] Support binary comparisons between Unsigned Long and other numeric types #110663

Open
Tracked by #110661
not-napoleon opened this issue Jul 9, 2024 · 1 comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@not-napoleon
Copy link
Member

Currently, binary comparisons between unsigned longs and other numeric types are unsupported. Supporting comparisons however does not require resolving any of the tricky casting questions that arithmetic needs to figure out. We know that all negative numbers are strictly less than all unsigned longs, so we can just return appropriately. For non-negative values, ints and longs can safely be cast to unsigned longs, and unsigned longs can be cast to double (which is lossy, but is what longs do)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

2 participants