Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to merge mappings of field named properties #108866

Closed
eyalkoren opened this issue May 21, 2024 · 3 comments · Fixed by #108867
Closed

Failure to merge mappings of field named properties #108866

eyalkoren opened this issue May 21, 2024 · 3 comments · Fixed by #108867
Assignees
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch

Comments

@eyalkoren
Copy link
Contributor

Elasticsearch Version

8.14.0

Installed Plugins

No response

Java Version

bundled

OS Version

Darwin

Problem Description

The new merge algorithm of raw field mappings that was merged through #97317 introduced a new failure when merging mappings of fields named properties. See details in the comment posted to the related PR.

Steps to Reproduce

Merging:

  "template": {
    "mappings": {
      "properties": {
        "properties": {
          "properties": {
            "child1": {
              "type": "text"
            }
          }
        }
      }
    }
  }

with:

  "template": {
    "mappings": {
      "properties": {
        "properties": {
          "properties": {
            "child2": {
              "type": "long"
            }
          }
        }
      }
    }
  }

should yield:

  "template": {
    "mappings": {
      "properties": {
        "properties": {
          "properties": {
            "child1": {
              "type": "text"
            },
            "child2": {
              "type": "long"
            }
          }
        }
      }
    }
  }

but instead yields:

  "template": {
    "mappings": {
      "properties": {
        "properties": {
          "properties": {
            "child2": {
              "type": "long"
            }
          }
        }
      }
    }
  }

Logs (if relevant)

No response

@eyalkoren eyalkoren added >bug needs:triage Requires assignment of a team area label labels May 21, 2024
@eyalkoren eyalkoren self-assigned this May 21, 2024
@gbanasiak gbanasiak added the :Search Foundations/Mapping Index mappings, including merging and defining field types label May 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team and removed needs:triage Requires assignment of a team area label labels May 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@eyalkoren
Copy link
Contributor Author

@chiarch84 the fix has been merged and backported.
Once 8.14.1 is released, please try again and let us know if the issue has been resolved.

@chiarch84
Copy link

Super! Thanks for your help! I'll let you know!

@javanna javanna added Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch and removed Team:Search Meta label for search team labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants