Skip to content

Commit

Permalink
Test: Remove broken yml test feature (#31255)
Browse files Browse the repository at this point in the history
The `requires_replica` yaml test feature hasn't worked for years. This
is what happens if you try to use it:
```
   > Throwable #1: java.lang.NullPointerException
   >    at __randomizedtesting.SeedInfo.seed([E6602FB306244B12:6E341069A8D826EA]:0)
   >    at org.elasticsearch.test.rest.yaml.Features.areAllSupported(Features.java:58)
   >    at org.elasticsearch.test.rest.yaml.section.SkipSection.skip(SkipSection.java:144)
   >    at org.elasticsearch.test.rest.yaml.ESClientYamlSuiteTestCase.test(ESClientYamlSuiteTestCase.java:321)
```

None of our tests use it.
  • Loading branch information
nik9000 authored Jun 13, 2018
1 parent 24163d1 commit 77bb935
Showing 1 changed file with 0 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

package org.elasticsearch.test.rest.yaml;

import org.elasticsearch.test.ESIntegTestCase;

import java.util.Arrays;
import java.util.List;

Expand Down Expand Up @@ -56,9 +54,6 @@ private Features() {
*/
public static boolean areAllSupported(List<String> features) {
for (String feature : features) {
if ("requires_replica".equals(feature) && ESIntegTestCase.cluster().numDataNodes() >= 2) {
continue;
}
if (!SUPPORTED.contains(feature)) {
return false;
}
Expand Down

0 comments on commit 77bb935

Please sign in to comment.