Skip to content

Commit

Permalink
Use @AwaitsFix instead of @ignore
Browse files Browse the repository at this point in the history
  • Loading branch information
dimitris-athanasiou committed Jun 11, 2018
1 parent 58caa58 commit 4de4447
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -45,14 +45,14 @@
/**
* An integration test for detection rules
*/
@Ignore
public class DetectionRulesIT extends MlNativeAutodetectIntegTestCase {

@After
public void cleanUpTest() throws Exception {
cleanUp();
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testNumericalRule() throws Exception {
RuleCondition condition1 = RuleCondition.createNumerical(
RuleConditionType.NUMERICAL_ACTUAL,
Expand Down Expand Up @@ -154,6 +154,7 @@ public void testNumericalRule() throws Exception {
assertThat(secondHaldRecordByFieldValues, contains("by_field_value_1", "by_field_value_2"));
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testCategoricalRule() throws Exception {
MlFilter safeIps = new MlFilter("safe_ips", Arrays.asList("111.111.111.111", "222.222.222.222"));
assertThat(putMlFilter(safeIps), is(true));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,14 @@
import static org.hamcrest.Matchers.equalTo;
import static org.hamcrest.Matchers.is;

@Ignore
public class ScheduledEventsIT extends MlNativeAutodetectIntegTestCase {

@After
public void cleanUpTest() {
cleanUp();
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testScheduledEvents() throws IOException {

TimeValue bucketSpan = TimeValue.timeValueMinutes(30);
Expand Down Expand Up @@ -154,6 +154,7 @@ public void testScheduledEvents() throws IOException {
assertThat(records, is(empty()));
}

@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testScheduledEventWithInterimResults() throws IOException {
TimeValue bucketSpan = TimeValue.timeValueMinutes(30);
Job.Builder job = createJob("scheduled-events-interim-results", bucketSpan);
Expand Down Expand Up @@ -195,6 +196,7 @@ public void testScheduledEventWithInterimResults() throws IOException {
/**
* Test an open job picks up changes to scheduled events/calendars
*/
@AwaitsFix(bugUrl = "this test is muted temporarily until the new rules implementation is merged in")
public void testOnlineUpdate() throws Exception {
TimeValue bucketSpan = TimeValue.timeValueMinutes(30);
Job.Builder job = createJob("scheduled-events-online-update", bucketSpan);
Expand Down

0 comments on commit 4de4447

Please sign in to comment.