From 2f0aca992bb8c91c17603050807891cad2e41483 Mon Sep 17 00:00:00 2001 From: Mark Vieira Date: Sun, 15 Mar 2020 18:10:40 -0700 Subject: [PATCH] Revert "Upgrade to Jackson 2.10.3 and GeoIP2 to 2.13.1 (#53576)" This reverts commit b7dbadeea075a409b68122291853587dca529e94. --- buildSrc/version.properties | 8 ++++++-- .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + libs/x-content/build.gradle | 1 - .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + .../jackson-dataformat-cbor-2.10.3.jar.sha1 | 1 - .../jackson-dataformat-cbor-2.8.11.jar.sha1 | 1 + .../jackson-dataformat-smile-2.10.3.jar.sha1 | 1 - .../jackson-dataformat-smile-2.8.11.jar.sha1 | 1 + .../jackson-dataformat-yaml-2.10.3.jar.sha1 | 1 - .../jackson-dataformat-yaml-2.8.11.jar.sha1 | 1 + .../licenses/snakeyaml-1.17.jar.sha1 | 1 + .../licenses/snakeyaml-1.24.jar.sha1 | 1 - .../common/xcontent/XContentParserTests.java | 19 ++++++++----------- .../ingest/common/JsonProcessorTests.java | 9 ++------- modules/ingest-geoip/build.gradle | 10 ++++++---- .../licenses/geoip2-2.13.1.jar.sha1 | 1 - .../licenses/geoip2-2.9.0.jar.sha1 | 1 + .../jackson-annotations-2.10.3.jar.sha1 | 1 - .../jackson-annotations-2.8.11.jar.sha1 | 1 + .../licenses/jackson-databind-2.10.3.jar.sha1 | 1 - .../jackson-databind-2.8.11.6.jar.sha1 | 1 + .../licenses/maxmind-db-1.2.2.jar.sha1 | 1 + .../licenses/maxmind-db-1.3.1.jar.sha1 | 1 - plugins/discovery-ec2/build.gradle | 2 +- .../jackson-annotations-2.10.3.jar.sha1 | 1 - .../jackson-annotations-2.8.11.jar.sha1 | 1 + .../licenses/jackson-databind-2.10.3.jar.sha1 | 1 - .../jackson-databind-2.8.11.6.jar.sha1 | 1 + plugins/repository-s3/build.gradle | 2 +- .../jackson-annotations-2.10.3.jar.sha1 | 1 - .../jackson-annotations-2.8.11.jar.sha1 | 1 + .../licenses/jackson-databind-2.10.3.jar.sha1 | 1 - .../jackson-databind-2.8.11.6.jar.sha1 | 1 + .../xcontent/XContentParserUtilsTests.java | 11 ++++++++++- .../index/IndexingSlowLogTests.java | 8 ++++---- x-pack/plugin/sql/jdbc/build.gradle | 5 ----- .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + .../jackson-dataformat-cbor-2.10.3.jar.sha1 | 1 - .../jackson-dataformat-cbor-2.8.11.jar.sha1 | 1 + .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + .../xpack/sql/client/RemoteFailureTests.java | 5 ++--- .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + x-pack/snapshot-tool/build.gradle | 2 +- .../jackson-annotations-2.10.3.jar.sha1 | 1 - .../jackson-annotations-2.8.11.jar.sha1 | 1 + .../licenses/jackson-core-2.10.3.jar.sha1 | 1 - .../licenses/jackson-core-2.8.11.jar.sha1 | 1 + .../licenses/jackson-databind-2.10.3.jar.sha1 | 1 - .../jackson-databind-2.8.11.6.jar.sha1 | 1 + 56 files changed, 63 insertions(+), 63 deletions(-) delete mode 100644 client/sniffer/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 client/sniffer/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 libs/x-content/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 libs/x-content/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 libs/x-content/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 create mode 100644 libs/x-content/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 delete mode 100644 libs/x-content/licenses/jackson-dataformat-smile-2.10.3.jar.sha1 create mode 100644 libs/x-content/licenses/jackson-dataformat-smile-2.8.11.jar.sha1 delete mode 100644 libs/x-content/licenses/jackson-dataformat-yaml-2.10.3.jar.sha1 create mode 100644 libs/x-content/licenses/jackson-dataformat-yaml-2.8.11.jar.sha1 create mode 100644 libs/x-content/licenses/snakeyaml-1.17.jar.sha1 delete mode 100644 libs/x-content/licenses/snakeyaml-1.24.jar.sha1 delete mode 100644 modules/ingest-geoip/licenses/geoip2-2.13.1.jar.sha1 create mode 100644 modules/ingest-geoip/licenses/geoip2-2.9.0.jar.sha1 delete mode 100644 modules/ingest-geoip/licenses/jackson-annotations-2.10.3.jar.sha1 create mode 100644 modules/ingest-geoip/licenses/jackson-annotations-2.8.11.jar.sha1 delete mode 100644 modules/ingest-geoip/licenses/jackson-databind-2.10.3.jar.sha1 create mode 100644 modules/ingest-geoip/licenses/jackson-databind-2.8.11.6.jar.sha1 create mode 100644 modules/ingest-geoip/licenses/maxmind-db-1.2.2.jar.sha1 delete mode 100644 modules/ingest-geoip/licenses/maxmind-db-1.3.1.jar.sha1 delete mode 100644 plugins/discovery-ec2/licenses/jackson-annotations-2.10.3.jar.sha1 create mode 100644 plugins/discovery-ec2/licenses/jackson-annotations-2.8.11.jar.sha1 delete mode 100644 plugins/discovery-ec2/licenses/jackson-databind-2.10.3.jar.sha1 create mode 100644 plugins/discovery-ec2/licenses/jackson-databind-2.8.11.6.jar.sha1 delete mode 100644 plugins/repository-s3/licenses/jackson-annotations-2.10.3.jar.sha1 create mode 100644 plugins/repository-s3/licenses/jackson-annotations-2.8.11.jar.sha1 delete mode 100644 plugins/repository-s3/licenses/jackson-databind-2.10.3.jar.sha1 create mode 100644 plugins/repository-s3/licenses/jackson-databind-2.8.11.6.jar.sha1 delete mode 100644 x-pack/plugin/sql/jdbc/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 x-pack/plugin/sql/jdbc/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 create mode 100644 x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 delete mode 100644 x-pack/plugin/sql/sql-action/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 x-pack/plugin/sql/sql-action/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 x-pack/plugin/sql/sql-client/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 x-pack/plugin/sql/sql-client/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 x-pack/snapshot-tool/licenses/jackson-annotations-2.10.3.jar.sha1 create mode 100644 x-pack/snapshot-tool/licenses/jackson-annotations-2.8.11.jar.sha1 delete mode 100644 x-pack/snapshot-tool/licenses/jackson-core-2.10.3.jar.sha1 create mode 100644 x-pack/snapshot-tool/licenses/jackson-core-2.8.11.jar.sha1 delete mode 100644 x-pack/snapshot-tool/licenses/jackson-databind-2.10.3.jar.sha1 create mode 100644 x-pack/snapshot-tool/licenses/jackson-databind-2.8.11.6.jar.sha1 diff --git a/buildSrc/version.properties b/buildSrc/version.properties index 544e20b3b069f..c746ad45a3509 100644 --- a/buildSrc/version.properties +++ b/buildSrc/version.properties @@ -7,8 +7,12 @@ bundled_jdk = 13.0.2+8 # optional dependencies spatial4j = 0.7 jts = 1.15.0 -jackson = 2.10.3 -snakeyaml = 1.24 +# note that ingest-geoip has a hard-coded version; if you modify this version, +# you should also inspect that version to see if it can be advanced along with +# the com.maxmind.geoip2:geoip2 dependency +jackson = 2.8.11 +jacksondatabind = 2.8.11.6 +snakeyaml = 1.17 icu4j = 62.1 supercsv = 2.4.0 # when updating log4j, please update also docs/java-api/index.asciidoc diff --git a/client/sniffer/licenses/jackson-core-2.10.3.jar.sha1 b/client/sniffer/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/client/sniffer/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/client/sniffer/licenses/jackson-core-2.8.11.jar.sha1 b/client/sniffer/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/client/sniffer/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/libs/x-content/build.gradle b/libs/x-content/build.gradle index be056980ef50d..14adf7d102d78 100644 --- a/libs/x-content/build.gradle +++ b/libs/x-content/build.gradle @@ -49,7 +49,6 @@ forbiddenApisMain { thirdPartyAudit.ignoreMissingClasses( // from com.fasterxml.jackson.dataformat.yaml.YAMLMapper (jackson-dataformat-yaml) 'com.fasterxml.jackson.databind.ObjectMapper', - 'com.fasterxml.jackson.databind.cfg.MapperBuilder' ) dependencyLicenses { diff --git a/libs/x-content/licenses/jackson-core-2.10.3.jar.sha1 b/libs/x-content/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/libs/x-content/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-core-2.8.11.jar.sha1 b/libs/x-content/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/libs/x-content/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 b/libs/x-content/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 deleted file mode 100644 index 6c96c20f48232..0000000000000 --- a/libs/x-content/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -1ba01fef9c3b7ed388d91e71dc733b315c7374cd \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 b/libs/x-content/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..378ba524422bc --- /dev/null +++ b/libs/x-content/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 @@ -0,0 +1 @@ +8b9826e16c3366764bfb7ad7362554f0471046c3 \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-dataformat-smile-2.10.3.jar.sha1 b/libs/x-content/licenses/jackson-dataformat-smile-2.10.3.jar.sha1 deleted file mode 100644 index 24ac4b32095e4..0000000000000 --- a/libs/x-content/licenses/jackson-dataformat-smile-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -ff397547ff168e77279a1cd549e2ca4923c991aa \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-dataformat-smile-2.8.11.jar.sha1 b/libs/x-content/licenses/jackson-dataformat-smile-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..510afb3df53e6 --- /dev/null +++ b/libs/x-content/licenses/jackson-dataformat-smile-2.8.11.jar.sha1 @@ -0,0 +1 @@ +d9d1c49c5d9d5e46e2aee55f3cdd119286fe0fc1 \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-dataformat-yaml-2.10.3.jar.sha1 b/libs/x-content/licenses/jackson-dataformat-yaml-2.10.3.jar.sha1 deleted file mode 100644 index 8f1ecab9ecb38..0000000000000 --- a/libs/x-content/licenses/jackson-dataformat-yaml-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -4dc1a172812d9da27c1afd6a08f4f12aad7b14dd \ No newline at end of file diff --git a/libs/x-content/licenses/jackson-dataformat-yaml-2.8.11.jar.sha1 b/libs/x-content/licenses/jackson-dataformat-yaml-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..78a68d715ec3d --- /dev/null +++ b/libs/x-content/licenses/jackson-dataformat-yaml-2.8.11.jar.sha1 @@ -0,0 +1 @@ +2e77c6ff7342cd61ab1ae7cb14ed16aebfc8a72a \ No newline at end of file diff --git a/libs/x-content/licenses/snakeyaml-1.17.jar.sha1 b/libs/x-content/licenses/snakeyaml-1.17.jar.sha1 new file mode 100644 index 0000000000000..9ac6e87f2244a --- /dev/null +++ b/libs/x-content/licenses/snakeyaml-1.17.jar.sha1 @@ -0,0 +1 @@ +7a27ea250c5130b2922b86dea63cbb1cc10a660c \ No newline at end of file diff --git a/libs/x-content/licenses/snakeyaml-1.24.jar.sha1 b/libs/x-content/licenses/snakeyaml-1.24.jar.sha1 deleted file mode 100644 index a6e7bd5a1e7c1..0000000000000 --- a/libs/x-content/licenses/snakeyaml-1.24.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -13a9c0d6776483c3876e3ff9384f9bb55b17001b \ No newline at end of file diff --git a/libs/x-content/src/test/java/org/elasticsearch/common/xcontent/XContentParserTests.java b/libs/x-content/src/test/java/org/elasticsearch/common/xcontent/XContentParserTests.java index 4e2688ee0a0de..cc5804a6ce7fc 100644 --- a/libs/x-content/src/test/java/org/elasticsearch/common/xcontent/XContentParserTests.java +++ b/libs/x-content/src/test/java/org/elasticsearch/common/xcontent/XContentParserTests.java @@ -78,17 +78,14 @@ public void testFloat() throws IOException { assertEquals(value, number.floatValue(), 0.0f); - switch (xContentType) { - case CBOR: - case SMILE: - assertThat(number, instanceOf(Float.class)); - break; - case JSON: - case YAML: - assertThat(number, instanceOf(Double.class)); - break; - default: - throw new AssertionError("unexpected x-content type [" + xContentType + "]"); + if (xContentType == XContentType.CBOR) { + // CBOR parses back a float + assertTrue(number instanceof Float); + } else { + // JSON, YAML and SMILE parses back the float value as a double + // This will change for SMILE in Jackson 2.9 where all binary based + // formats will return a float + assertTrue(number instanceof Double); } } } diff --git a/modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/JsonProcessorTests.java b/modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/JsonProcessorTests.java index c9e81ccf4c811..099e8e1866b8e 100644 --- a/modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/JsonProcessorTests.java +++ b/modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/JsonProcessorTests.java @@ -65,7 +65,7 @@ public void testInvalidValue() { Exception exception = expectThrows(IllegalArgumentException.class, () -> jsonProcessor.execute(ingestDocument)); assertThat(exception.getCause().getMessage(), containsString("Unrecognized token 'blah': " + - "was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')")); + "was expecting ('true', 'false' or 'null')")); } public void testByteArray() { @@ -75,12 +75,7 @@ public void testByteArray() { IngestDocument ingestDocument = RandomDocumentPicks.randomIngestDocument(random(), document); Exception exception = expectThrows(IllegalArgumentException.class, () -> jsonProcessor.execute(ingestDocument)); - assertThat( - exception.getCause().getMessage(), - containsString( - "Unrecognized token 'B': was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')" - ) - ); + assertThat(exception.getCause().getMessage(), containsString("Unrecognized token 'B': was expecting ('true', 'false' or 'null')")); } public void testNull() throws Exception { diff --git a/modules/ingest-geoip/build.gradle b/modules/ingest-geoip/build.gradle index 944b3d55a1124..2d7910210971a 100644 --- a/modules/ingest-geoip/build.gradle +++ b/modules/ingest-geoip/build.gradle @@ -25,11 +25,13 @@ esplugin { } dependencies { - compile('com.maxmind.geoip2:geoip2:2.13.1') + // Upgrade to 2.10.0 or higher when jackson-core gets upgraded to 2.9.x. Blocked by #27032 + compile('com.maxmind.geoip2:geoip2:2.9.0') // geoip2 dependencies: - compile("com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}") - compile("com.fasterxml.jackson.core:jackson-databind:${versions.jackson}") - compile('com.maxmind.db:maxmind-db:1.3.1') + // do not hardcode this to the version in version.properties, it needs to be upgraded separately with geoip2 + compile("com.fasterxml.jackson.core:jackson-annotations:2.8.11") + compile("com.fasterxml.jackson.core:jackson-databind:2.8.11.6") + compile('com.maxmind.db:maxmind-db:1.2.2') testCompile 'org.elasticsearch:geolite2-databases:20191119' } diff --git a/modules/ingest-geoip/licenses/geoip2-2.13.1.jar.sha1 b/modules/ingest-geoip/licenses/geoip2-2.13.1.jar.sha1 deleted file mode 100644 index 253d9f12e7a3a..0000000000000 --- a/modules/ingest-geoip/licenses/geoip2-2.13.1.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f27d1a49d5a29dd4a7ac5006ce2eb16b8b9bb888 \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/geoip2-2.9.0.jar.sha1 b/modules/ingest-geoip/licenses/geoip2-2.9.0.jar.sha1 new file mode 100644 index 0000000000000..8cb79bbb9207a --- /dev/null +++ b/modules/ingest-geoip/licenses/geoip2-2.9.0.jar.sha1 @@ -0,0 +1 @@ +c12b463a2c10824225c0b27952c49b464cb0e4c6 \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/jackson-annotations-2.10.3.jar.sha1 b/modules/ingest-geoip/licenses/jackson-annotations-2.10.3.jar.sha1 deleted file mode 100644 index 9c725f2d90e69..0000000000000 --- a/modules/ingest-geoip/licenses/jackson-annotations-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -0f63b3b1da563767d04d2e4d3fc1ae0cdeffebe7 \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/jackson-annotations-2.8.11.jar.sha1 b/modules/ingest-geoip/licenses/jackson-annotations-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..30e7d1a7b1a74 --- /dev/null +++ b/modules/ingest-geoip/licenses/jackson-annotations-2.8.11.jar.sha1 @@ -0,0 +1 @@ +391de20b4e29cb3fb07d2454ace64be2c82ac91f \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/jackson-databind-2.10.3.jar.sha1 b/modules/ingest-geoip/licenses/jackson-databind-2.10.3.jar.sha1 deleted file mode 100644 index 688ae92d10792..0000000000000 --- a/modules/ingest-geoip/licenses/jackson-databind-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -aae92628b5447fa25af79871ca98668da6edd439 \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/jackson-databind-2.8.11.6.jar.sha1 b/modules/ingest-geoip/licenses/jackson-databind-2.8.11.6.jar.sha1 new file mode 100644 index 0000000000000..f491259db56bc --- /dev/null +++ b/modules/ingest-geoip/licenses/jackson-databind-2.8.11.6.jar.sha1 @@ -0,0 +1 @@ +35753201d0cdb1dbe998ab289bca1180b68d4368 \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/maxmind-db-1.2.2.jar.sha1 b/modules/ingest-geoip/licenses/maxmind-db-1.2.2.jar.sha1 new file mode 100644 index 0000000000000..3dd3ad36f4cc3 --- /dev/null +++ b/modules/ingest-geoip/licenses/maxmind-db-1.2.2.jar.sha1 @@ -0,0 +1 @@ +78c22a03de1e222b0751855aff7bb6e6db5569e5 \ No newline at end of file diff --git a/modules/ingest-geoip/licenses/maxmind-db-1.3.1.jar.sha1 b/modules/ingest-geoip/licenses/maxmind-db-1.3.1.jar.sha1 deleted file mode 100644 index aebff2c3a849c..0000000000000 --- a/modules/ingest-geoip/licenses/maxmind-db-1.3.1.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -211bca628225bc0f719051b16deb03a747d7a14f \ No newline at end of file diff --git a/plugins/discovery-ec2/build.gradle b/plugins/discovery-ec2/build.gradle index 401a204b3ea3c..e92dddf1f2b31 100644 --- a/plugins/discovery-ec2/build.gradle +++ b/plugins/discovery-ec2/build.gradle @@ -36,7 +36,7 @@ dependencies { compile "commons-logging:commons-logging:${versions.commonslogging}" compile "org.apache.logging.log4j:log4j-1.2-api:${versions.log4j}" compile "commons-codec:commons-codec:${versions.commonscodec}" - compile "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}" + compile "com.fasterxml.jackson.core:jackson-databind:${versions.jacksondatabind}" compile "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}" } diff --git a/plugins/discovery-ec2/licenses/jackson-annotations-2.10.3.jar.sha1 b/plugins/discovery-ec2/licenses/jackson-annotations-2.10.3.jar.sha1 deleted file mode 100644 index 9c725f2d90e69..0000000000000 --- a/plugins/discovery-ec2/licenses/jackson-annotations-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -0f63b3b1da563767d04d2e4d3fc1ae0cdeffebe7 \ No newline at end of file diff --git a/plugins/discovery-ec2/licenses/jackson-annotations-2.8.11.jar.sha1 b/plugins/discovery-ec2/licenses/jackson-annotations-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..30e7d1a7b1a74 --- /dev/null +++ b/plugins/discovery-ec2/licenses/jackson-annotations-2.8.11.jar.sha1 @@ -0,0 +1 @@ +391de20b4e29cb3fb07d2454ace64be2c82ac91f \ No newline at end of file diff --git a/plugins/discovery-ec2/licenses/jackson-databind-2.10.3.jar.sha1 b/plugins/discovery-ec2/licenses/jackson-databind-2.10.3.jar.sha1 deleted file mode 100644 index 688ae92d10792..0000000000000 --- a/plugins/discovery-ec2/licenses/jackson-databind-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -aae92628b5447fa25af79871ca98668da6edd439 \ No newline at end of file diff --git a/plugins/discovery-ec2/licenses/jackson-databind-2.8.11.6.jar.sha1 b/plugins/discovery-ec2/licenses/jackson-databind-2.8.11.6.jar.sha1 new file mode 100644 index 0000000000000..f491259db56bc --- /dev/null +++ b/plugins/discovery-ec2/licenses/jackson-databind-2.8.11.6.jar.sha1 @@ -0,0 +1 @@ +35753201d0cdb1dbe998ab289bca1180b68d4368 \ No newline at end of file diff --git a/plugins/repository-s3/build.gradle b/plugins/repository-s3/build.gradle index ef765fe51e591..6ddee431a1c03 100644 --- a/plugins/repository-s3/build.gradle +++ b/plugins/repository-s3/build.gradle @@ -43,7 +43,7 @@ dependencies { compile "org.apache.logging.log4j:log4j-1.2-api:${versions.log4j}" compile "commons-codec:commons-codec:${versions.commonscodec}" compile "com.fasterxml.jackson.core:jackson-core:${versions.jackson}" - compile "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}" + compile "com.fasterxml.jackson.core:jackson-databind:${versions.jacksondatabind}" compile "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}" compile "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:${versions.jackson}" compile "joda-time:joda-time:${versions.joda}" diff --git a/plugins/repository-s3/licenses/jackson-annotations-2.10.3.jar.sha1 b/plugins/repository-s3/licenses/jackson-annotations-2.10.3.jar.sha1 deleted file mode 100644 index 9c725f2d90e69..0000000000000 --- a/plugins/repository-s3/licenses/jackson-annotations-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -0f63b3b1da563767d04d2e4d3fc1ae0cdeffebe7 \ No newline at end of file diff --git a/plugins/repository-s3/licenses/jackson-annotations-2.8.11.jar.sha1 b/plugins/repository-s3/licenses/jackson-annotations-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..30e7d1a7b1a74 --- /dev/null +++ b/plugins/repository-s3/licenses/jackson-annotations-2.8.11.jar.sha1 @@ -0,0 +1 @@ +391de20b4e29cb3fb07d2454ace64be2c82ac91f \ No newline at end of file diff --git a/plugins/repository-s3/licenses/jackson-databind-2.10.3.jar.sha1 b/plugins/repository-s3/licenses/jackson-databind-2.10.3.jar.sha1 deleted file mode 100644 index 688ae92d10792..0000000000000 --- a/plugins/repository-s3/licenses/jackson-databind-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -aae92628b5447fa25af79871ca98668da6edd439 \ No newline at end of file diff --git a/plugins/repository-s3/licenses/jackson-databind-2.8.11.6.jar.sha1 b/plugins/repository-s3/licenses/jackson-databind-2.8.11.6.jar.sha1 new file mode 100644 index 0000000000000..f491259db56bc --- /dev/null +++ b/plugins/repository-s3/licenses/jackson-databind-2.8.11.6.jar.sha1 @@ -0,0 +1 @@ +35753201d0cdb1dbe998ab289bca1180b68d4368 \ No newline at end of file diff --git a/server/src/test/java/org/elasticsearch/common/xcontent/XContentParserUtilsTests.java b/server/src/test/java/org/elasticsearch/common/xcontent/XContentParserUtilsTests.java index 6b99f28f3a8c1..db3dabdcafe49 100644 --- a/server/src/test/java/org/elasticsearch/common/xcontent/XContentParserUtilsTests.java +++ b/server/src/test/java/org/elasticsearch/common/xcontent/XContentParserUtilsTests.java @@ -31,6 +31,7 @@ import java.io.IOException; import java.util.ArrayList; +import java.util.Base64; import java.util.List; import java.util.Map; @@ -89,7 +90,15 @@ public void testStoredFieldsValueBoolean() throws IOException { public void testStoredFieldsValueBinary() throws IOException { final byte[] value = randomUnicodeOfLength(scaledRandomIntBetween(10, 1000)).getBytes("UTF-8"); - assertParseFieldsSimpleValue(value, (xcontentType, result) -> assertArrayEquals(value, ((BytesArray) result).array())); + assertParseFieldsSimpleValue(value, (xcontentType, result) -> { + if (xcontentType == XContentType.JSON || xcontentType == XContentType.YAML) { + //binary values will be parsed back and returned as base64 strings when reading from json and yaml + assertArrayEquals(value, Base64.getDecoder().decode((String) result)); + } else { + //binary values will be parsed back and returned as BytesArray when reading from cbor and smile + assertArrayEquals(value, ((BytesArray) result).array()); + } + }); } public void testStoredFieldsValueNull() throws IOException { diff --git a/server/src/test/java/org/elasticsearch/index/IndexingSlowLogTests.java b/server/src/test/java/org/elasticsearch/index/IndexingSlowLogTests.java index e7a729263e089..68d71ae476b98 100644 --- a/server/src/test/java/org/elasticsearch/index/IndexingSlowLogTests.java +++ b/server/src/test/java/org/elasticsearch/index/IndexingSlowLogTests.java @@ -105,13 +105,13 @@ public void testSlowLogParsedDocumentPrinterSourceToLog() throws IOException { final UncheckedIOException e = expectThrows(UncheckedIOException.class, ()->new IndexingSlowLogMessage(index, doc, 10, true, 3)); assertThat(e, hasToString(containsString("_failed_to_convert_[Unrecognized token 'invalid':" - + " was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')\\n" - + " at [Source: (org.elasticsearch.common.bytes.AbstractBytesReference$MarkSupportingStreamInputWrapper)"))); + + " was expecting ('true', 'false' or 'null')\\n" + + " at [Source: org.elasticsearch.common.bytes.AbstractBytesReference$MarkSupportingStreamInputWrapper"))); assertNotNull(e.getCause()); assertThat(e.getCause(), instanceOf(JsonParseException.class)); assertThat(e.getCause(), hasToString(containsString("Unrecognized token 'invalid':" - + " was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')\n" - + " at [Source: (org.elasticsearch.common.bytes.AbstractBytesReference$MarkSupportingStreamInputWrapper)"))); + + " was expecting ('true', 'false' or 'null')\n" + + " at [Source: org.elasticsearch.common.bytes.AbstractBytesReference$MarkSupportingStreamInputWrapper"))); } public void testReformatSetting() { diff --git a/x-pack/plugin/sql/jdbc/build.gradle b/x-pack/plugin/sql/jdbc/build.gradle index dc42f90476571..7cdec567ef8f4 100644 --- a/x-pack/plugin/sql/jdbc/build.gradle +++ b/x-pack/plugin/sql/jdbc/build.gradle @@ -44,8 +44,3 @@ dependencyLicenses { shadowJar { relocate 'com.fasterxml', 'org.elasticsearch.fasterxml' } - -thirdPartyAudit.ignoreMissingClasses( - 'com.fasterxml.jackson.databind.ObjectMapper', - 'com.fasterxml.jackson.databind.cfg.MapperBuilder' -) diff --git a/x-pack/plugin/sql/jdbc/licenses/jackson-core-2.10.3.jar.sha1 b/x-pack/plugin/sql/jdbc/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/x-pack/plugin/sql/jdbc/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/x-pack/plugin/sql/jdbc/licenses/jackson-core-2.8.11.jar.sha1 b/x-pack/plugin/sql/jdbc/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/x-pack/plugin/sql/jdbc/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 b/x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 deleted file mode 100644 index 6c96c20f48232..0000000000000 --- a/x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -1ba01fef9c3b7ed388d91e71dc733b315c7374cd \ No newline at end of file diff --git a/x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 b/x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..378ba524422bc --- /dev/null +++ b/x-pack/plugin/sql/jdbc/licenses/jackson-dataformat-cbor-2.8.11.jar.sha1 @@ -0,0 +1 @@ +8b9826e16c3366764bfb7ad7362554f0471046c3 \ No newline at end of file diff --git a/x-pack/plugin/sql/sql-action/licenses/jackson-core-2.10.3.jar.sha1 b/x-pack/plugin/sql/sql-action/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/x-pack/plugin/sql/sql-action/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/x-pack/plugin/sql/sql-action/licenses/jackson-core-2.8.11.jar.sha1 b/x-pack/plugin/sql/sql-action/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/x-pack/plugin/sql/sql-action/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/x-pack/plugin/sql/sql-client/licenses/jackson-core-2.10.3.jar.sha1 b/x-pack/plugin/sql/sql-client/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/x-pack/plugin/sql/sql-client/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/x-pack/plugin/sql/sql-client/licenses/jackson-core-2.8.11.jar.sha1 b/x-pack/plugin/sql/sql-client/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/x-pack/plugin/sql/sql-client/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/x-pack/plugin/sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/RemoteFailureTests.java b/x-pack/plugin/sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/RemoteFailureTests.java index 1409e80837768..2029493bcbec4 100644 --- a/x-pack/plugin/sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/RemoteFailureTests.java +++ b/x-pack/plugin/sql/sql-client/src/test/java/org/elasticsearch/xpack/sql/client/RemoteFailureTests.java @@ -92,8 +92,7 @@ public void testNoType() { public void testInvalidJson() { IOException e = expectThrows(IOException.class, () -> parse("invalid_json.txt")); assertEquals( - "Can't parse error from Elasticsearch [Unrecognized token 'I': " - + "was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')] " + "Can't parse error from Elasticsearch [Unrecognized token 'I': was expecting 'null', 'true', 'false' or NaN] " + "at [line 1 col 1]. Response:\n" + "I'm not json at all", e.getMessage()); @@ -119,7 +118,7 @@ public void testTotalGarbage() { }).streamInput())); assertThat(e.getMessage(), startsWith("Can't parse error from Elasticsearch [Unrecognized token 'ΓΏ': " - + "was expecting (JSON String, Number, Array, Object or token 'null', 'true' or 'false')] at [line 1 col 4]. Response:\n")); + + "was expecting ('true', 'false' or 'null')] at [line 1 col 1]. Response:\n")); } public void testTooBig() { diff --git a/x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.10.3.jar.sha1 b/x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.8.11.jar.sha1 b/x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/x-pack/plugin/sql/sql-proto/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/x-pack/snapshot-tool/build.gradle b/x-pack/snapshot-tool/build.gradle index 31c17ba4c3590..14ce3ea7a0844 100644 --- a/x-pack/snapshot-tool/build.gradle +++ b/x-pack/snapshot-tool/build.gradle @@ -26,7 +26,7 @@ dependencies { compile "commons-codec:commons-codec:${versions.commonscodec}" compile "org.apache.logging.log4j:log4j-1.2-api:${versions.log4j}" compile "com.fasterxml.jackson.core:jackson-core:${versions.jackson}" - compile "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}" + compile "com.fasterxml.jackson.core:jackson-databind:${versions.jacksondatabind}" compile "com.fasterxml.jackson.core:jackson-annotations:${versions.jackson}" // GCS dependencies diff --git a/x-pack/snapshot-tool/licenses/jackson-annotations-2.10.3.jar.sha1 b/x-pack/snapshot-tool/licenses/jackson-annotations-2.10.3.jar.sha1 deleted file mode 100644 index 9c725f2d90e69..0000000000000 --- a/x-pack/snapshot-tool/licenses/jackson-annotations-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -0f63b3b1da563767d04d2e4d3fc1ae0cdeffebe7 \ No newline at end of file diff --git a/x-pack/snapshot-tool/licenses/jackson-annotations-2.8.11.jar.sha1 b/x-pack/snapshot-tool/licenses/jackson-annotations-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..30e7d1a7b1a74 --- /dev/null +++ b/x-pack/snapshot-tool/licenses/jackson-annotations-2.8.11.jar.sha1 @@ -0,0 +1 @@ +391de20b4e29cb3fb07d2454ace64be2c82ac91f \ No newline at end of file diff --git a/x-pack/snapshot-tool/licenses/jackson-core-2.10.3.jar.sha1 b/x-pack/snapshot-tool/licenses/jackson-core-2.10.3.jar.sha1 deleted file mode 100644 index f23937b0d82a4..0000000000000 --- a/x-pack/snapshot-tool/licenses/jackson-core-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -f7ee7b55c7d292ac72fbaa7648c089f069c938d2 \ No newline at end of file diff --git a/x-pack/snapshot-tool/licenses/jackson-core-2.8.11.jar.sha1 b/x-pack/snapshot-tool/licenses/jackson-core-2.8.11.jar.sha1 new file mode 100644 index 0000000000000..e7ad1e74ed6b8 --- /dev/null +++ b/x-pack/snapshot-tool/licenses/jackson-core-2.8.11.jar.sha1 @@ -0,0 +1 @@ +876ead1db19f0c9e79c9789273a3ef8c6fd6c29b \ No newline at end of file diff --git a/x-pack/snapshot-tool/licenses/jackson-databind-2.10.3.jar.sha1 b/x-pack/snapshot-tool/licenses/jackson-databind-2.10.3.jar.sha1 deleted file mode 100644 index 688ae92d10792..0000000000000 --- a/x-pack/snapshot-tool/licenses/jackson-databind-2.10.3.jar.sha1 +++ /dev/null @@ -1 +0,0 @@ -aae92628b5447fa25af79871ca98668da6edd439 \ No newline at end of file diff --git a/x-pack/snapshot-tool/licenses/jackson-databind-2.8.11.6.jar.sha1 b/x-pack/snapshot-tool/licenses/jackson-databind-2.8.11.6.jar.sha1 new file mode 100644 index 0000000000000..f491259db56bc --- /dev/null +++ b/x-pack/snapshot-tool/licenses/jackson-databind-2.8.11.6.jar.sha1 @@ -0,0 +1 @@ +35753201d0cdb1dbe998ab289bca1180b68d4368 \ No newline at end of file