Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Micrometer integration #541

Closed
patpatpat123 opened this issue Mar 26, 2023 · 2 comments
Closed

[Feature Request] Micrometer integration #541

patpatpat123 opened this issue Mar 26, 2023 · 2 comments

Comments

@patpatpat123
Copy link

Description

Hello Elastic team,

This is my first writing in this repo although I am using the client on a regular basis.
If not anything, thank you for this project.

I wanted to start this feature request enhancement request, asking if it is possible to add micrometer to this project.

Metrics and tracing are vital component of any production level component.
Therefore, in each of our projects, any integration we have with ElasticSearch using this elasticsearch-java client, we need to manually add tracing and metrics.

For instance, when we have a read or write operation with elastic, using the blocking or async api, one has to manually create metrics. (number of write, time taken, count of errors, etc), alongside traces correlating the application calling the read write (parent) to elasticsearch-java client (child trace).

Apologies to repeat myself, but since metrics and tracing are vital component of production level applications, would it be possible to have built in to this project:

  • metrics for read write operations with ElasticSearch
  • traces for read write operations with ElasticSearch

Thank you

@swallez
Copy link
Member

swallez commented Mar 31, 2023

This has already been discussed and ultimately rejected in elastic/elasticsearch#93591 (comment)

@swallez swallez closed this as completed Mar 31, 2023
@swallez
Copy link
Member

swallez commented Aug 21, 2023

@patpatpat123 PR #588 adds an instrumentation API with a default implementation based on OpenTelemetry. Adding an implementation based on Micrometer should be fairly straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants