Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultisearchBody Should Support Highlight and Source #288

Closed
rsahlstrom opened this issue May 18, 2022 · 1 comment · Fixed by #292
Closed

MultisearchBody Should Support Highlight and Source #288

rsahlstrom opened this issue May 18, 2022 · 1 comment · Fixed by #292
Labels
Area: Specification Related to the API spec used to generate client code

Comments

@rsahlstrom
Copy link

Description

The MultisearchBody does not let you do everything you can when making manually JSON calls. For example, this SDK does not allow you to specify:

  • highlight
  • _source.includes or _source.excludes

As a result, I'm doing multiple SearchRequests calls instead of a single msesarch request.
@swallez swallez added the Area: Specification Related to the API spec used to generate client code label May 24, 2022
This was referenced May 24, 2022
Merged
Merged
This was referenced May 24, 2022
Merged
Merged
@swallez
Copy link
Member

swallez commented May 24, 2022

This has been fixed in PR #292, backported to version 8.2 in PR #293 and to version 7.17 in PR #294.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Specification Related to the API spec used to generate client code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[codegen] Update to latest API spec elastic/elasticsearch-java
2 participants
@swallez @rsahlstrom