Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support script id/file/inline options #538

Closed
costin opened this issue Aug 20, 2015 · 6 comments
Closed

Support script id/file/inline options #538

costin opened this issue Aug 20, 2015 · 6 comments

Comments

@costin
Copy link
Member

costin commented Aug 20, 2015

Scripting has added new options such as id, file or inline. This should be supported as well by the connector.

@costin
Copy link
Member Author

costin commented Aug 20, 2015

Also include the new options such as detect_noop, scripted_as_upsert, etc...

@costin
Copy link
Member Author

costin commented Oct 15, 2015

related #553

@costin costin added v2.2.0 and removed v2.2.0-rc1 labels Jan 8, 2016
@costin costin added v2.3.0 and removed v2.2.0 labels Jan 31, 2016
@costin costin added v2.3.2 and removed v2.3.1 labels May 3, 2016
@costin costin added v2.3.3 and removed v2.3.2 labels May 18, 2016
@jbaiera jbaiera added v2.3.4 and removed v2.3.3 labels Jul 6, 2016
@jbaiera jbaiera added v2.3.5 and removed v2.3.4 labels Aug 2, 2016
@jbaiera jbaiera added v2.4.1 and removed v2.3.5 labels Aug 25, 2016
@jbaiera jbaiera added v5.0.1 and removed v2.4.1 labels Oct 26, 2016
@jbaiera jbaiera added the v5.0.2 label Nov 17, 2016
@Weizilla
Copy link

Weizilla commented Mar 18, 2020

@costin Is the Scripted Upsert feature supported? I found a discussion about it referring to this PR but there's no mention of it on the official configuration page.

@jbaiera
Copy link
Member

jbaiera commented Mar 18, 2020

@Weizilla This issue is very old. I would recommend against resurrecting old closed issues, especially with direct mentions to contributors. Much better to start a forum post or open a new issue.

Scripted Upsert is unfortunately not supported at the moment, but I don't think it would be so hard to add. Feel free to open a new issue for that. PR's are also very welcome. I believe that would be a pretty easy setting to add.

@Weizilla
Copy link

@jbaiera Sorry about that, I figured it was better to reference existing issues than make duplicates.

I found a PR that's similar #1080 but you talked about This will need to work for frameworks other than Spark.. Could you elaborate on that? Frameworks in this context means Map/Reduce, Hive, etc?

@jbaiera
Copy link
Member

jbaiera commented Mar 20, 2020

That specific PR was opened in an incomplete state and doesn't look like it ever was revisited. In terms of PRs working for frameworks other than Spark, yes, you are correct. Changes to the core packages must be compatible with all integrations, and new features in those core packages are encouraged to be added in a way that they can be used by all integrations as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants