Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA fingerprint comparison of SHA-256 strings should support both colon-separated hex string and lowercase string #107

Closed
JoshMock opened this issue Jun 27, 2024 · 1 comment · Fixed by #112
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@JoshMock
Copy link
Member

🐛 Bug Report

As noted in observablehq/framework#1490, the caFingerprint option fails when comparing a SHA-256 string that is provided as all lowercase, no colons (e.g. a1b2c3d4 rather than A1:B2:C3:D4). The lowercase format is what Elasticsearch prints to the console on startup, which fails the string comparison and is a confusing experience. All fingerprints should be normalized to the same format before comparison.

@JoshMock
Copy link
Member Author

Just released this in v8.7.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant