Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for elastic-agent-complete to Elastic Package #510

Closed
dominiqueclarke opened this issue Sep 15, 2021 · 6 comments
Closed

Add support for elastic-agent-complete to Elastic Package #510

dominiqueclarke opened this issue Sep 15, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request Team:Uptime Label for the Uptime team

Comments

@dominiqueclarke
Copy link

The elastic-package stack up command currently enrolls a standard agent using the mainline elastic-agent image.

We should configure the command to also enroll a complete agent using the elastic-agent-complete image, or provide a flag to determine which type of agent to enroll.

@dominiqueclarke dominiqueclarke added enhancement New feature or request Team:Uptime Label for the Uptime team labels Sep 15, 2021
@mtojek
Copy link
Contributor

mtojek commented Sep 16, 2021

@dominiqueclarke Thank you for the reference PR, but we need to rethink how to support it. Adding an extra container with agent might be a performance overkill here, so maybe it's valid to replace/extend the original elastic-agent image instead.

The "elastic-agent-complete" means that it includes "heartbeat", right? Could you please share image details? How much is that image heavier than standard one. Maybe we can just switch it to complete.

@dominiqueclarke
Copy link
Author

Thanks @mtojek. The elastic-agent-complete image contains all the binaries necessary to run beats, plus additional dependencies required to run the synthetics agent via heartbeat. This includes node, chromium, playwright, the synthetics agent itself and more.

Reference ticket: elastic/beats#26398
Agent image (~400MB bigger than the original): https://container-library.elastic.co/r/beats/elastic-agent-complete?show_snapshots=true

The complete image will indeed cover the scope of existing capabilities of the mainline Elastic Agent, so it would make sense to switch the agent over to complete.

@mtojek
Copy link
Contributor

mtojek commented Sep 21, 2021

We can try to replace the agent with "complete" variant and observe. Let's first wait until the issue with faulty elastic-agent is solved (waiting for new snapshots get published) and then we'll try.

If everything goes well, we'll leave just the "complete" one.

@mtojek
Copy link
Contributor

mtojek commented Sep 22, 2021

Version bump for elastic/integrations: elastic/integrations#1748

@mtojek
Copy link
Contributor

mtojek commented Sep 22, 2021

Ok, I see that we need a small workaround for stacks < 7.15.0, where elastic-agent-complete wasn't available.

@mtojek
Copy link
Contributor

mtojek commented Oct 4, 2021

I guess we can close this issue as it's deployed in elastic/integrations.

@mtojek mtojek closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Uptime Label for the Uptime team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants