Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command: lint the integration #5

Closed
mtojek opened this issue Jun 5, 2020 · 5 comments · Fixed by #42
Closed

Command: lint the integration #5

mtojek opened this issue Jun 5, 2020 · 5 comments · Fixed by #42
Assignees
Labels

Comments

@mtojek
Copy link
Contributor

mtojek commented Jun 5, 2020

The command runs a basic validation of the package content, it doesn’t necessarily need to build the content. YAML manifests, JSON files, mandatory files, etc. It also verifies if dashboard file are properly encoded.

The command exposes a flag that fails when any file modification is required (for "check" purposes). It must be part of the implementation.

Suggested command: elastic-package lint

@ycombinator
Copy link
Contributor

Hey @mtojek, I was going through these issues today and noticed we also have elastic-package check. What are the differences between elastic-package validate and elastic-package check?

@andresrc
Copy link
Collaborator

same question here

@mtojek
Copy link
Contributor Author

mtojek commented Jul 24, 2020

I responded here: #10 (comment)

@exekias
Copy link

exekias commented Jul 30, 2020

I understand where we are coming from, perhaps we could call this lint? I'm not against validate per se, but for me it's easy to confuse validate and check, as they could be doing the same thing.

With lint and check I clearly see what may be the difference.

@mtojek
Copy link
Contributor Author

mtojek commented Jul 30, 2020

Good point, I prefer the lint over validate. I will adjust also: #31

@mtojek mtojek changed the title Command: validate the integration Command: lint the integration Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants