Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discuss] opt-in to new HTTP semantic conventions #381

Closed
david-luna opened this issue Sep 30, 2024 · 1 comment
Closed

[discuss] opt-in to new HTTP semantic conventions #381

david-luna opened this issue Sep 30, 2024 · 1 comment

Comments

@david-luna
Copy link
Member

@opentelemetry/instrumentation-http added the possibility to opt-in to the stable HTTP semantic conventions for span attributes
ref: open-telemetry/opentelemetry-js#4978

As we can see in the announcement there is a env var to opt-in for the new stable attribs (OTEL_SEMCONV_STABILITY_OPT_IN).

Should the distro have a default configuration value of http which tells the instrumentation to emit only stable attributes or should it keep it as is?

@david-luna
Copy link
Member Author

discussed in https://github.com/elastic/apm-nodejs-dev/issues/57 and decided:

  • EDOT should behave like upstream, so we won't change defaults
  • make sure we document this and encourage users to opt-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant