Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js default metrics dashboards #132

Closed
estolfo opened this issue Apr 11, 2024 · 4 comments
Closed

Node.js default metrics dashboards #132

estolfo opened this issue Apr 11, 2024 · 4 comments
Assignees

Comments

@estolfo
Copy link

estolfo commented Apr 11, 2024

Let's make sure metrics dashboards are shown for the OTel distro in the Metrics tab and that the metrics shown are meaningful. This task might also require some UI task coordination and portable dashboard work.
If work was done for this issue, it's possible some of it could be reused.

@david-luna
Copy link
Member

david-luna commented Apr 17, 2024

As for now Kibana does no differentiate between native SDK or our distro. This PR landed in 8.13 to display memory metrics for OTEL agents and was used in the EAH to show the memory metrics exported by our distro.

About portable dashboards there is this contrib PR. It stays open since I didn't test with other agents, my bad. I could ping someone from Java or another language to do try it out.

@david-luna
Copy link
Member

david-luna commented May 14, 2024

As agreed in today's APM agents meeting (2024-05-14) the metrics tab should contain only runtime related metrics, in our case node metrics. There is already a PR to add these into semantic conventions open-telemetry/semantic-conventions#990

We should wait for these metrics to land then check on https://www.npmjs.com/package/@opentelemetry/instrumentation-runtime-node and do the proper updates into the upstream repo

@AlexanderWert AlexanderWert changed the title Default metrics dashboards Node.js default metrics dashboards May 16, 2024
@david-luna
Copy link
Member

Kibana PR created elastic/kibana#199353

Next steps

  • add @opentelemetry/instrumentation-runtime-metrics in EDOT for Node.js once published (ref)
  • release a new version of EDOT for Node.js

@david-luna
Copy link
Member

Dashboard also backported to 8.x (kudos to @trentm)
elastic/kibana#200810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants