Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor naming unification #984

Merged
merged 3 commits into from
Jan 19, 2021
Merged

chore: minor naming unification #984

merged 3 commits into from
Jan 19, 2021

Conversation

monfera
Copy link
Contributor

@monfera monfera commented Jan 19, 2021 •
edited
Loading

Summary

No functional or API change, just unifying some names, see by commit. Was going to slap it to a PR but it'd have made review difficult.

Both common and commons are legit terms, though the former is more common in current master and in most software repos, and these are local utils, so leaned toward the former, as we had both

@monfera monfera added the chore label Jan 19, 2021
@monfera monfera requested a review from markov00 January 19, 2021 18:23
@codecov-io
Copy link

codecov-io commented Jan 19, 2021 •
edited
Loading

Codecov Report

Merging #984 (5a1f708) into master (f06a57a) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   70.80%   70.89%   +0.08%     
==========================================
  Files         345      361      +16     
  Lines       10998    10626     -372     
  Branches     2314     2177     -137     
==========================================
- Hits         7787     7533     -254     
+ Misses       3198     3004     -194     
- Partials       13       89      +76
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/chart_types/goal_chart/state/chart_state.tsx 57.89% <ø> (+0.99%) ⬆️
...l_chart/state/selectors/on_element_click_caller.ts 36.00% <ø> (+1.38%) ⬆️
...al_chart/state/selectors/on_element_over_caller.ts 18.42% <ø> (+0.47%) ⬆️
...rt_types/heatmap/state/selectors/compute_legend.ts 42.85% <ø> (+2.85%) ⬆️
...heatmap/state/selectors/on_element_click_caller.ts 32.14% <ø> (+1.10%) ⬆️
.../heatmap/state/selectors/on_element_over_caller.ts 22.85% <ø> (+0.63%) ⬆️
src/chart_types/heatmap/utils/common.ts 20.00% <ø> (ø)
...types/partition_chart/layout/types/config_types.ts 100.00% <ø> (ø)
.../chart_types/partition_chart/layout/types/types.ts 100.00% <ø> (ø)
...es/partition_chart/layout/types/viewmodel_types.ts 83.33% <ø> (ø)
... and 329 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06a57a...5a1f708. Read the comment docs.

monfera
monfera commented Jan 19, 2021
View reviewed changes
wiki/overview.md
@@ -205,9 +205,9 @@ On the current `Visualize Editor`, you can stack or cluster in the following cas

### Multiple charts/Split charts/Small Multiples (phase 2)

Small multiples are created using the `<SmallMultiples>` component, that takes multiple `<SplittedSeries>` component with the usual element inside. `<SplittedSeries>` can contain only `BarSeries` `AreaSeries` and `LineSeries` Axis and other configuration need to be configured outside the `SplittedSeries` element.
Small multiples are created using the `<SmallMultiples>` component, that takes multiple `<splitSeries>` component with the usual element inside. `<splitSeries>` can contain only `BarSeries` `AreaSeries` and `LineSeries` Axis and other configuration need to be configured outside the `splitSeries` element.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found a <SplittedSeries> so this doc line needs an update in a real PR (coming up later) so I avoid carbon waste by not pushing a restore to uppercase

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good robert, this file should be updated anyway as this is not more the way you can create a small multiple

markov00
markov00 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing my italianiglish :D
the .mdx files are not used yet so it is fine for me.
The same for the wiki overview file

@monfera
Merge remote-tracking branch 'origin/master' into minor-rename
5a1f708 
# Conflicts:
#	src/mocks/series/series_identifiers.ts
@monfera monfera merged commit dce139a into elastic:master Jan 19, 2021
@markov00
Copy link
Member

🎉 This PR is included in version 24.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
chore released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monfera @codecov-io @markov00