Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Legend] Legend dot Icon fixed id string breaks a11y tests #983

Closed
2 tasks done
dej611 opened this issue Jan 19, 2021 · 2 comments
Closed
2 tasks done

[Legend] Legend dot Icon fixed id string breaks a11y tests #983

dej611 opened this issue Jan 19, 2021 · 2 comments
Labels
:accessibility Accessibility related issue bug Something isn't working kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue

Comments

@dej611
Copy link
Contributor

dej611 commented Jan 19, 2021

Describe the bug
The Legend component is using the DotIcon underneath, which exposes a SVG component with a fixed id string: this leads to multiple DOM nodes with the same id value, which is a problem both in general and at a11y level.

Either remove the id (but it is probably used somewhere else) or assign a configurable/dynamic id to it.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://elastic.github.io/elastic-charts/?path=/story/bubble-chart-alpha--multiple (but any other viz with multiple series will work)
  2. Execute this JS code in the console: document.querySelectorAll('#dot-a').length
  3. Notice the result being > 1

Expected behaviour
Unique id used in the visualization DOM tree.

Kibana Cross Issues
Kibana Lens issue

Checklist

  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@dej611 dej611 added bug Something isn't working kibana cross issue Has a Kibana issue counterpart :accessibility Accessibility related issue :Lens Kibana Lens related issue labels Jan 19, 2021
@nickofthyme
Copy link
Collaborator

nickofthyme commented Jan 19, 2021

I think this is a duplicate of #970 which was fixed by #973. Please confirm.

@dej611
Copy link
Contributor Author

dej611 commented Jan 19, 2021

Oh sorry, didn't find #970 while searching. I guess it can be closed then 👍
Waiting for the next release to close it on the Kibana side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:accessibility Accessibility related issue bug Something isn't working kibana cross issue Has a Kibana issue counterpart :Lens Kibana Lens related issue
Projects
None yet
Development

No branches or pull requests

2 participants