Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty labels on debug state #940

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: empty labels on debug state #940

merged 1 commit into from
Dec 7, 2020

Conversation

nickofthyme
Copy link
Collaborator

@nickofthyme nickofthyme commented Dec 7, 2020 •
edited
Loading

Summary

When using the new debugState, the axis labels where using the non-filtered ticks when using either showOverlappingLabels or showOverlappingTicks options. This PR uses only the visible ticks and filters out empty string labels.

Checklist

  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme requested a review from rshen91 December 7, 2020 18:34
rshen91
rshen91 approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@rshen91 rshen91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested locally

@codecov-io
Copy link

Codecov Report

Merging #940 (d02e585) into master (7e4512b) will increase coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #940      +/-   ##
==========================================
+ Coverage   70.13%   70.20%   +0.07%     
==========================================
  Files         342      358      +16     
  Lines       11026    10657     -369     
  Branches     2391     2060     -331     
==========================================
- Hits         7733     7482     -251     
+ Misses       3279     3089     -190     
- Partials       14       86      +72
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._types/xy_chart/state/selectors/get_debug_state.ts 47.00% <0.00%> (-3.46%) ⬇️
src/utils/dimensions.ts 71.42% <0.00%> (-28.58%) ⬇️
src/components/no_results.tsx 50.00% <0.00%> (-25.00%) ⬇️
src/chart_types/xy_chart/utils/panel_utils.ts 72.72% <0.00%> (-19.59%) ⬇️
src/components/error_boundary/errors.ts 50.00% <0.00%> (-16.67%) ⬇️
src/utils/data_generators/data_generator.ts 45.45% <0.00%> (-9.10%) ⬇️
...t/state/selectors/compute_small_multiple_scales.ts 86.95% <0.00%> (-8.70%) ⬇️
src/components/portal/utils.ts 21.42% <0.00%> (-7.15%) ⬇️
.../partition_chart/state/selectors/compute_legend.ts 79.06% <0.00%> (-5.72%) ⬇️
...state/selectors/get_internal_is_tooltip_visible.ts 75.00% <0.00%> (-5.00%) ⬇️
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4512b...d02e585. Read the comment docs.

@nickofthyme nickofthyme merged commit 3c823fd into elastic:master Dec 7, 2020
@nickofthyme nickofthyme deleted the empty-labels-debug branch December 7, 2020 19:52
markov00 pushed a commit that referenced this pull request Dec 9, 2020
@semantic-release-bot
chore(release): 24.4.0 [skip ci]
bda63f6 
# [24.4.0](v24.3.0...v24.4.0) (2020-12-09)

### Bug Fixes

* empty labels on debug state ([#940](#940)) ([3c823fd](3c823fd))

### Features

* allow use of functions for y, y0, split and stack accessors ([#943](#943)) ([22425d3](22425d3))
@markov00
Copy link
Member

markov00 commented Dec 9, 2020

🎉 This PR is included in version 24.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Dec 9, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 24.4.0 [skip ci]
4d929d0 
# [24.4.0](elastic/elastic-charts@v24.3.0...v24.4.0) (2020-12-09)

### Bug Fixes

* empty labels on debug state ([opensearch-project#940](elastic/elastic-charts#940)) ([3d1281b](elastic/elastic-charts@3d1281b))

### Features

* allow use of functions for y, y0, split and stack accessors ([opensearch-project#943](elastic/elastic-charts#943)) ([e881723](elastic/elastic-charts@e881723))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rshen91 rshen91 rshen91 approved these changes

Assignees
No one assigned
Labels
released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickofthyme @codecov-io @markov00 @rshen91