-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: legend dark mode hover color #820
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -16,7 +16,7 @@ $legendItemVerticalPadding: $echLegendRowGap / 2; | |||
} | |||
|
|||
&:hover { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should actually only get background color on :focus
. Leaving the underline as the hover state.
&:hover { | |
&:focus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, at the moment we don't have accessible interactions on the legend and thus focus
would do nothing. This will be revisited in #580.
Are you ok with it being hover
until then?
Co-authored-by: Elizabet Oliveira <[email protected]>
In favor of #820 (review)
🎉 This PR is included in version 21.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# [21.3.0](elastic/elastic-charts@v21.2.0...v21.3.0) (2020-09-16) ### Bug Fixes * legend dark mode hover color ([opensearch-project#820](elastic/elastic-charts#820)) ([d30c21f](elastic/elastic-charts@d30c21f)) ### Features * cancel brush/click event with escape key ([opensearch-project#819](elastic/elastic-charts#819)) ([5a9f21f](elastic/elastic-charts@5a9f21f)) * show crosshair for external pointer events ([opensearch-project#817](elastic/elastic-charts#817)) ([1721514](elastic/elastic-charts@1721514))
Summary
Related to elastic/kibana#77283
Fixes bad styles for dark theme after changes to legend item hover styles in #749
Checklist
src/index.ts
(and stories only import from../src
except for test data & storybook)