fix(axis): misaligned axis with rotated histogram #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickofthyme
added
bug
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 74.36% 74.35% -0.01%
==========================================
Files 273 273
Lines 9318 9323 +5
Branches 2007 2011 +4
==========================================
+ Hits 6929 6932 +3
- Misses 2382 2383 +1
- Partials 7 8 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Confirmed correct alignment by overlaying 0 degree with 180 and 90 degree with -90. Ticks match perfectly with these changes. Bottom axis
Left axis
|
markov00
pushed a commit
that referenced
this pull request
Sep 6, 2020
# [21.1.0](v21.0.1...v21.1.0) (2020-09-06) ### Bug Fixes * **axis:** misaligned axis with rotated histogram bar charts ([#805](#805)) ([6c454e1](6c454e1)) ### Features * **brush:** histogram brushing last values and rounding ([#801](#801)) ([6d0319f](6d0319f)) * **tooltip:** series tick formatters ([#802](#802)) ([fbcd92e](fbcd92e))
|
🎉 This PR is included in version 21.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [21.1.0](elastic/elastic-charts@v21.0.1...v21.1.0) (2020-09-06) ### Bug Fixes * **axis:** misaligned axis with rotated histogram bar charts ([opensearch-project#805](elastic/elastic-charts#805)) ([a52a692](elastic/elastic-charts@a52a692)) ### Features * **brush:** histogram brushing last values and rounding ([opensearch-project#801](elastic/elastic-charts#801)) ([867abbc](elastic/elastic-charts@867abbc)) * **tooltip:** series tick formatters ([opensearch-project#802](elastic/elastic-charts#802)) ([813b915](elastic/elastic-charts@813b915))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #800
This PR provides a low risk fix to the misaligned axis for rotated histogram bar charts.
Added vrt to validate this change in the future
After screenshots
Checklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)