Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(axis): draw grid lines separately from axis tick and customize style with config #8

Merged
merged 7 commits into from
Jan 31, 2019

Conversation

emmacunningham
Copy link
Contributor

@emmacunningham emmacunningham commented Jan 30, 2019

This PR separates the grid lines from the axis ticks so that grid lines can be styled independently of tick lines.

Current the grid line styles can be customized by:

  • stroke color
  • stroke width
  • opacity
  • dash

image

@emmacunningham emmacunningham changed the title feat: draw grid lines separately from axis tick and customize style with config [WIP] feat: draw grid lines separately from axis tick and customize style with config Jan 30, 2019
@emmacunningham emmacunningham force-pushed the feature/custom-grid-lines branch from 530fcbd to ac9d86c Compare January 30, 2019 18:49
@emmacunningham emmacunningham changed the title [WIP] feat: draw grid lines separately from axis tick and customize style with config feat: draw grid lines separately from axis tick and customize style with config Jan 30, 2019
@emmacunningham emmacunningham changed the title feat: draw grid lines separately from axis tick and customize style with config feat(axis): draw grid lines separately from axis tick and customize style with config Jan 30, 2019
@markov00 markov00 merged commit ab7e974 into elastic:master Jan 31, 2019
markov00 pushed a commit that referenced this pull request Feb 7, 2019
# 1.0.0 (2019-02-07)

### Bug Fixes

* reflect specs ids on legend items when using single series ([8b39f15](8b39f15))
* **axis:** add axisTitleHeight to axis increments ([#29](#29)) ([e34f0ae](e34f0ae)), closes [#26](#26)
* **axis:** fix horizontal title positioning to account for title padding ([08d1f83](08d1f83))
* **axis:** scale tick labels to fix text truncation on chrome ([#38](#38)) ([99c2332](99c2332)), closes [#18](#18)
* **axis:** use titleFontSize for debug rect for horizontal axis title ([#17](#17)) ([af4aa58](af4aa58)), closes [#11](#11)
* **dimensions:** use chart top padding in computation of chart height ([42585f7](42585f7)), closes [#13](#13)
* **x_domain:** fix x value asc sorting using numbers ([26b33ff](26b33ff))

### Features

* add tickLabelRotation and showGridLines features ([#7](#7)) ([47f118b](47f118b))
* **axis:** draw grid lines separately from axis tick and customize style with config ([#8](#8)) ([ab7e974](ab7e974))
@emmacunningham emmacunningham deleted the feature/custom-grid-lines branch March 7, 2019 16:02
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
# 1.0.0 (2019-02-07)

### Bug Fixes

* reflect specs ids on legend items when using single series ([ecbe4c6](elastic/elastic-charts@ecbe4c6))
* **axis:** add axisTitleHeight to axis increments ([opensearch-project#29](elastic/elastic-charts#29)) ([1f4b48b](elastic/elastic-charts@1f4b48b)), closes [opensearch-project#26](elastic/elastic-charts#26)
* **axis:** fix horizontal title positioning to account for title padding ([d167af6](elastic/elastic-charts@d167af6))
* **axis:** scale tick labels to fix text truncation on chrome ([opensearch-project#38](elastic/elastic-charts#38)) ([3e6a400](elastic/elastic-charts@3e6a400)), closes [opensearch-project#18](elastic/elastic-charts#18)
* **axis:** use titleFontSize for debug rect for horizontal axis title ([opensearch-project#17](elastic/elastic-charts#17)) ([7e5f7d6](elastic/elastic-charts@7e5f7d6)), closes [#11](elastic/elastic-charts#11)
* **dimensions:** use chart top padding in computation of chart height ([4bc5ac8](elastic/elastic-charts@4bc5ac8)), closes [#13](elastic/elastic-charts#13)
* **x_domain:** fix x value asc sorting using numbers ([f64c6aa](elastic/elastic-charts@f64c6aa))

### Features

* add tickLabelRotation and showGridLines features ([#7](elastic/elastic-charts#7)) ([ced76ce](elastic/elastic-charts@ced76ce))
* **axis:** draw grid lines separately from axis tick and customize style with config ([#8](elastic/elastic-charts#8)) ([411950b](elastic/elastic-charts@411950b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants