Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for legend item interactions #79

Closed
4 tasks done
emmacunningham opened this issue Feb 27, 2019 · 4 comments
Closed
4 tasks done

Update UI for legend item interactions #79

emmacunningham opened this issue Feb 27, 2019 · 4 comments
Labels
enhancement New feature or request :legend Legend related issue

Comments

@emmacunningham
Copy link
Contributor

emmacunningham commented Feb 27, 2019

Is your feature request related to a problem? Please describe.
See discussions from other issues/PRs:
#25 (comment)
#51

Describe the solution you'd like
Would like to settle on what the UI for the legend items interactions should be. This would cover:

  • How to handle the color picker (in current Kibana, it is opened in the same panel as the +/- buttons for removing/focusing a data series, but initial feedback was that this should be independent of that panel and open up just by click on the dot)
  • How to handle chart internal data series visibility toggling. This is currently not a feature in Kibana, but the idea is that separate from actual removal/focus of the data for an actual series (i.e. what currently happens when you click +/- in Kibana), there should be a way to keep the data for a series but not render it within the chart. This includes:
    • How to show/hide a series within the context of other series being visible (e.g. if I have series a, b, c; I want to toggle the visibility of a while keeping b & c visible)
    • How to show/hide a series individually (which also toggles the visibility of the other series); an example of this is say I have series a, b, c, I want to toggle showing only a (making b & c not visible) and showing everything but a (making b & c visible).
  • How to handle chart external data series filtering. This is currently the functionality of the +/- buttons in Kibana. The new chart library is agnostic to what actually happens on these events, but it is a way for an application to bind some custom functionality to these interactions so that when a user interacts in these ways, the data for identifying the series gets passed to the custom listeners which can define their own behaviors, e.g. a new query with the values passed to the listener as a filter.

Describe alternatives you've considered
See the links in the first section for some options discussed and current implementation.

Additional context

Kibana Cross Issues

Checklist

  • this request is checked against already exist requests
  • [] every related Kibana issue is listed under Kibana Cross Issues list
  • [] kibana cross issue tag is associated to the issue if any kibana cross issue is present
@emmacunningham emmacunningham added the enhancement New feature or request label Feb 27, 2019
@markov00 markov00 changed the title Update UI for legend item interactions [interactions] Update UI for legend item interactions Feb 28, 2019
@markov00 markov00 added the :interactions Interactions related issue label Feb 28, 2019
@markov00 markov00 changed the title [interactions] Update UI for legend item interactions Update UI for legend item interactions Feb 28, 2019
@emmacunningham emmacunningham added the :legend Legend related issue label Mar 8, 2019
@emmacunningham
Copy link
Contributor Author

emmacunningham commented Mar 19, 2019

Notes from our bi-weekly sync today:

  • make sure there are title attributes for legend title items
  • legend item should be: [color dot] [title] [button to expand context menu w/ options]
    • color dot functionality will stay as is (though color picker component will need to be passed in instead imported). perhaps if no color picker component is passed in, then you cannot change the color.
    • show/hide series on legend title click (currently on eye icon next to title; this icon will go away)
    • add button next to title which will toggle open/close of context menu with +/- buttons and optionally other items
  • instead of directly importing EUI components, instead we will have downstream consumer of the library instead pass the components into the legend themselves. (they can also then pass in their own items into the context menu)

@emmacunningham
Copy link
Contributor Author

Currently the display value on horizontal legends is spaced incorrectly as below:

image

@markov00 markov00 mentioned this issue Mar 6, 2020
@nickofthyme
Copy link
Collaborator

FYI the comment above about spacing has been fixed

@markov00 markov00 removed the :interactions Interactions related issue label Mar 27, 2020
@markov00
Copy link
Member

closing this as the linked legend redesign issue already covers it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request :legend Legend related issue
Projects
None yet
Development

No branches or pull requests

3 participants