Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(axis): left axis sizing based on title padding #762

Merged
merged 4 commits into from
Jul 23, 2020
Merged

fix(axis): left axis sizing based on title padding #762

merged 4 commits into from
Jul 23, 2020

Conversation

nickofthyme
Copy link
Collaborator

Summary

Fix left axis size calculation. Titles as '' still included the padding in the axis dimensions but not in the charts dimensions, causing a misalignment.

Before

Screen Recording 2020-07-22 at 02 55 PM

After

Screen Recording 2020-07-22 at 02 48 PM

@nickofthyme nickofthyme added bug Something isn't working :axis Axis related issue regression labels Jul 22, 2020
@nickofthyme nickofthyme requested a review from markov00 July 22, 2020 20:01
markov00
markov00 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, I've also checked the same solution against the PR where we discovered this issue and this PR fix correctly the issue, LGTM

@markov00
Copy link
Member

jenkins test this please

@nickofthyme nickofthyme merged commit 3990589 into elastic:master Jul 23, 2020
@nickofthyme nickofthyme deleted the fix-left-axis-sizing branch July 23, 2020 13:47
markov00 pushed a commit that referenced this pull request Jul 23, 2020
@semantic-release-bot
chore(release): 20.0.2 [skip ci]
6f2e35d 
## [20.0.2](v20.0.1...v20.0.2) (2020-07-23)

### Bug Fixes

* **axis:** dual axis x positioning of bars ([#760](#760)) ([71b49f8](71b49f8))
* **axis:** left axis sizing based on title padding ([#762](#762)) ([3990589](3990589))
@markov00
Copy link
Member

🎉 This PR is included in version 20.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Jul 23, 2020
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 20.0.2 [skip ci]
6b03fc8 
## [20.0.2](elastic/elastic-charts@v20.0.1...v20.0.2) (2020-07-23)

### Bug Fixes

* **axis:** dual axis x positioning of bars ([opensearch-project#760](elastic/elastic-charts#760)) ([6afdbbd](elastic/elastic-charts@6afdbbd))
* **axis:** left axis sizing based on title padding ([opensearch-project#762](elastic/elastic-charts#762)) ([2fb4b84](elastic/elastic-charts@2fb4b84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

Assignees
No one assigned
Labels
:axis Axis related issue bug Something isn't working regression released Issue released publicly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickofthyme @markov00