-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty charts causing errors #657
fix: empty charts causing errors #657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 72.92% 72.94% +0.01%
==========================================
Files 266 266
Lines 8603 8618 +15
Branches 1690 1695 +5
==========================================
+ Hits 6274 6286 +12
- Misses 2290 2293 +3
Partials 39 39
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, fixes issue raised in kibana
## [19.1.1](v19.1.0...v19.1.1) (2020-04-30) ### Bug Fixes * render charts without series ([#657](#657)) ([0c0af01](0c0af01))
🎉 This PR is included in version 19.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
## [19.1.1](elastic/elastic-charts@v19.1.0...v19.1.1) (2020-04-30) ### Bug Fixes * render charts without series ([opensearch-project#657](elastic/elastic-charts#657)) ([311f04a](elastic/elastic-charts@311f04a))
Summary
This fix the error thrown when a chart is rendered without a series spec, usually caused how the consumer renders the chart components.
See the playground example and the comment here: elastic/kibana#64759 (comment)
Checklist
Delete any items that are not applicable to this PR.