fix: type issue pulling from src/index #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
issue related to jsx-eslint/eslint-plugin-react#2560
- add import/no-restricted-paths rule - prevent import anywhere in src/ from src/index.ts - prevent import anywhere in src outside of src
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 72.02% 72.52% +0.49%
==========================================
Files 246 259 +13
Lines 8165 8411 +246
Branches 1593 1633 +40
==========================================
+ Hits 5881 6100 +219
- Misses 2253 2276 +23
- Partials 31 35 +4
Continue to review full report at Codecov.
|
rshen91
approved these changes
Apr 22, 2020
There was a problem hiding this comment.
LGTM - doesn't affect stories being rendered (tested locally on Chrome). Es lint rule set up correctly and errors as expected when adding import '../../../scripts/custom_matchers'; in the file elastic-charts/src/utils/themes/colors.ts
markov00
approved these changes
Apr 22, 2020
markov00
pushed a commit
that referenced
this pull request
Apr 22, 2020
## [18.4.1](v18.4.0...v18.4.1) (2020-04-22) ### Bug Fixes * type issue pulling from src/index ([#645](#645)) ([3f3a996](3f3a996))
|
🎉 This PR is included in version 18.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [18.4.1](elastic/elastic-charts@v18.4.0...v18.4.1) (2020-04-22) ### Bug Fixes * type issue pulling from src/index ([opensearch-project#645](elastic/elastic-charts#645)) ([9c72967](elastic/elastic-charts@9c72967))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The typecheck for the built library includes surrounding files and directories, which when running the check
../../srcmay resolve to a module but this file is outside of thedistdirectory and will fail when checked in kibana.To prevent this in the future I added a linting rule to prevent imports from
src/index.tsand any parent directory/files of src.Also, fix tsconfig check to error on references outside of the dist folder.