fix(ie11): replace fast-deep-equal with an internal copy IE11 safe #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 75.57% 75.88% +0.30%
==========================================
Files 181 194 +13
Lines 5691 5879 +188
Branches 1104 1143 +39
==========================================
+ Hits 4301 4461 +160
- Misses 1374 1401 +27
- Partials 16 17 +1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
=========================================
+ Coverage 75.57% 75.88% +0.3%
=========================================
Files 181 194 +13
Lines 5691 5879 +188
Branches 1104 1143 +39
=========================================
+ Hits 4301 4461 +160
- Misses 1374 1401 +27
- Partials 16 17 +1
Continue to review full report at Codecov.
|
nickofthyme
approved these changes
Feb 10, 2020
markov00
added a commit
to markov00/elastic-charts
that referenced
this pull request
Feb 10, 2020
markov00
pushed a commit
that referenced
this pull request
Feb 10, 2020
## [17.0.3](v17.0.2...v17.0.3) (2020-02-10) ### Bug Fixes * **ie11:** replace fast-deep-equal with an internal copy IE11 safe ([#542](#542)) ([2a02d7d](2a02d7d))
|
🎉 This PR is included in version 17.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
markov00
added a commit
that referenced
this pull request
Feb 10, 2020
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
## [17.0.3](elastic/elastic-charts@v17.0.2...v17.0.3) (2020-02-10) ### Bug Fixes * **ie11:** replace fast-deep-equal with an internal copy IE11 safe ([opensearch-project#542](elastic/elastic-charts#542)) ([d202d7b](elastic/elastic-charts@d202d7b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This previous PR #534 introduced the
fast_deep_equallibrary to avoid multiple rendering on charts.Unfortunately, I didn't check if IE11 compatibility of the library during the PR review.
As described here: epoberezkin/fast-deep-equal#52 the library is not fully IE11 compatible if you just polyfill Maps/Sets. Some
for...ofloops are still there and can cause IE11 to fail if you don't transpile also the node modules.I've copied the code + license inside the library as a first quick workaround.
We will definitely remove the function/library when fixing the double rendering internally on our reselector chain.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.src/index.ts(and stories only import from../srcexcept for test data & storybook)[ ] Proper documentation or storybook story was added for features that require explanation or tutorials[ ] Unit tests were updated or added to match the most common scenarios